yate: increase max acceptable size of incoming SIP messages #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robho
force-pushed
the
yate_increase_sip_msg_size
branch
from
394d9b2
to
c13f357
Compare
Some SIP UAs support lots of features and codecs which results in large SIP messages. YATE, with its default configuration, truncates and fails to parse received SIP messages which are larger than 1500 bytes. Let's increase the default max message size for OpenWrt users to make it easier to use yate out-of-the-box. The new max size of 8192 bytes has been arbitrarily chosen. I've seen the SIP UA baresip produce messages larger than 1500 bytes with its default configuration when authentication is used. Signed-off-by: Robert Högberg <robert.hogberg@gmail.com>
robho
force-pushed
the
yate_increase_sip_msg_size
branch
from
c13f357
to
621352a
Compare
jslachta
approved these changes
Jun 11, 2021
|
Thank you, Robert (@robho)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some SIP UAs support lots of features and codecs which results in
large SIP messages. YATE, with its default configuration, truncates
and fails to parse received SIP messages which are larger than 1500
bytes. Let's increase the default max message size for OpenWrt users
to make it easier to use yate out-of-the-box.
The new max size of 8192 bytes has been arbitrarily chosen.
I've seen the SIP UA baresip produce messages larger than 1500 bytes
with its default configuration when authentication is used.
Signed-off-by: Robert Högberg robert.hogberg@gmail.com
Maintainer: @jslachta
Compile tested: No
Run tested: Only by manual configuration change. An increased maxpkt size works well for me. Verified with SIP UA baresip that had problems with YATE before the maxpkt increase.