Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extern type errors in kstat_osx.h #101

Open
rottegift opened this issue Sep 9, 2021 · 0 comments
Open

extern type errors in kstat_osx.h #101

rottegift opened this issue Sep 9, 2021 · 0 comments
Assignees

Comments

@rottegift
Copy link
Collaborator

An example:

$ sysctl -h kstat.zfs.darwin.tunable.zfs_trim_extent_bytes_max
kstat.zfs.darwin.tunable.zfs_trim_extent_bytes_max: 140,737,622,573,056

which is way different from its definition in module/zfs/vdev_trim.c:

unsigned int zfs_trim_extent_bytes_max = 128 * 1024 * 1024;

and the problem is because in include/os/macos/zfs/sys/kstat_osx.h:

extern uint64_t  zfs_trim_extent_bytes_max;

Todo: check the types of all the externs in kstat_osx.h, and/or figure out how to generate some build-time warning about this to catch when this happens.

@rottegift rottegift self-assigned this Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant