Skip to content
This repository has been archived by the owner on Apr 7, 2024. It is now read-only.

Enforce branch policies on this repository #14

Closed
7 tasks
toddysm opened this issue Mar 8, 2023 · 3 comments
Closed
7 tasks

Enforce branch policies on this repository #14

toddysm opened this issue Mar 8, 2023 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@toddysm
Copy link

toddysm commented Mar 8, 2023

To improve the security of the ORAS project we need to enforce the branch policies for this repository. I propose that we enforce the policies as follows:

  • Use the following rules for main and release/* branches:
    • Require PR before merging
      • Require 3 approvals
      • Dismiss stale PR approvals when new commits are pushed
      • Require review from Code Owners
      • Require status checks to pass before merging
      • Require conversation resolution before merging
      • Require signed commits
      • Do not allow bypass the above settings

Please add your comments and proposals for additional changes to this issue.

@shizhMSFT
Copy link
Contributor

Few comments:

  • release/* does not apply to libraries.
  • "Require 3 approvals" is not applicable to this repository since we only have 3 code owners.
  • Additionally, we require branches to be up to date before merging, which is useful but not captured in this issue.

It is worth noting that "require branches to be up to date before merging" somehow conflicts with "dismiss stale PR approvals when new commits are pushed".

@shizhMSFT shizhMSFT added the help wanted Extra attention is needed label Mar 20, 2023
@toddysm
Copy link
Author

toddysm commented Mar 20, 2023

The same comments as in oras-project/oras-go#458 (comment) and oras-project/oras#862 (comment)

@TerryHowe
Copy link
Member

I've updated the branch policies here to be similar to other oras libraries.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants