Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider optimizing the number of auth requests #1084

Closed
1 task done
Wwwsylvia opened this issue Aug 28, 2023 · 0 comments · Fixed by #1097
Closed
1 task done

Consider optimizing the number of auth requests #1084

Wwwsylvia opened this issue Aug 28, 2023 · 0 comments · Fixed by #1097
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Wwwsylvia
Copy link
Member

Wwwsylvia commented Aug 28, 2023

What is the version of your ORAS CLI

1.1.0-rc.2

What would you like to be added?

I was pushing an empty artifact using the below command and noticed that it took 9 requests to complete.

oras push $myreg/$myrepo:$mytag --debug

The requests were:

request #0: HEAD manifest digest - 401
request #1: POST token (scope: pull) - 200
request #2: HEAD manifest digest - 404
request #3: HEAD config ({}) - 404
request #4: POST config ({}) - 401
request #5: POST token (scope: pull, push) - 200
request #6: POST config ({}) - 202
request #7: PUT config ({}) - 201
request #8: PUT manifest tag - 201

It looks like the auth-related requests #4 and #5 (the one with underlines) can be saved on ORAS side.

Why is this needed for ORAS?

This can further improve the performance of ORAS.

Are you willing to submit PRs to contribute to this feature?

  • Yes, I am willing to implement it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants