Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NURBS.Curve.__eq__ returns True for different curves #174

Open
tomas16 opened this issue Jun 27, 2024 · 0 comments
Open

NURBS.Curve.__eq__ returns True for different curves #174

tomas16 opened this issue Jun 27, 2024 · 0 comments
Labels
bug There is a problem with the coding or algorithms

Comments

@tomas16
Copy link

tomas16 commented Jun 27, 2024

Describe the bug
I have several nurbs curves and they all compare equal to each other, which they shouldn't.
The issue seems to be here, where self._precision is 18 and my control points all have coordinates within [-10, 10] in X and Y. Note the same bug exists for the knot vector comparison a few lines up.

To Reproduce
Steps to reproduce the behavior:
Create 2 different nurbs curves with control points with small coordinate values and compare them.

Configuration:

  • OS: macOS
  • Python distribution: mambaforge
  • Python version: 3.11.9
  • geomdl install source: PyPI
  • geomdl version/branch: 5.3.1
@tomas16 tomas16 added the bug There is a problem with the coding or algorithms label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug There is a problem with the coding or algorithms
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomas16