Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exponential backoff for RPC calls to bitcoind not reset after successful calls #501

Closed
veryordinally opened this issue Sep 9, 2022 · 3 comments
Closed

Exponential backoff for RPC calls to bitcoind not reset after successful calls #501

veryordinally opened this issue Sep 9, 2022 · 3 comments

Comments

@veryordinally
Copy link
Collaborator

The exponential backoff (important currently to deal with #309) is not reset after a successful RPC call, so we give up once we have encountered 5 errors in total. The error counter should be reset after a successful RPC call to implement expected exponential backoff behavior.
@casey casey added bug labels Sep 9, 2022
@casey
Copy link
Collaborator

casey commented Sep 9, 2022

Good catch!

@veryordinally veryordinally mentioned this issue Sep 9, 2022
Closed
@veryordinally
Copy link
Collaborator Author

The fix is obviously trivial (reset errors to 0 after successful call), but given the bug is currently just in draft PR #495 this is more of a reminder.

@casey
Copy link
Collaborator

casey commented Sep 11, 2022

I think this is fixed

@casey casey closed this as completed Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@casey @veryordinally