Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Simplify testing #248

Open
croissanne opened this issue Sep 6, 2021 · 2 comments
Open

test: Simplify testing #248

croissanne opened this issue Sep 6, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@croissanne
Copy link
Member

croissanne commented Sep 6, 2021

Currently we test 4 different scenarios against osbuild-composer. However composer tests these scenarios already. Let's make CI as fast and reliable as possible while maintaining the same level of coverage.

Move as much as possible away from schutzbot and to github workflows. At the end we should just be validating the requests image-builder produces for composer.

These requests can be validated against composer's openapi spec as a start. But we should have additional checks for any additional information that image-builder adds before sending it to composer (correct repositories for instance). Note that with composerv2 the cloud/upload options will change quite a bit, so it's unclear if image-builder will add any cloud platform info in future other than for Azure.

Implementation-wise we could just write a mock server which checks requests against composer's api spec and does the additional checks.

Let's keep the quickest full rhel image-build (aws) as a sanity check, at least initially.

@lavocatt
Copy link
Contributor

lavocatt commented Sep 7, 2021

Also we need to check that the returned HTTP codes are the one we expect

@atodorov
Copy link
Contributor

atodorov commented Sep 9, 2021

CC myself so I don't forget. I've got some initial analysis on the topic but never managed to complete it.

@croissanne croissanne added the enhancement New feature or request label Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants