diff --git a/docs/src/DeveloperDocumentation/styleguide.md b/docs/src/DeveloperDocumentation/styleguide.md index 62f98cdb4645..f3b986eae60c 100644 --- a/docs/src/DeveloperDocumentation/styleguide.md +++ b/docs/src/DeveloperDocumentation/styleguide.md @@ -263,7 +263,7 @@ printing in Oscar](@ref). Sometimes it is necessary to rename a function or otherwise change it. To allow for backwards compatibility, please then introduce a new line in the file -`src/Deprecations.jl`. The syntax is as follows: +`src/deprecations.jl`. The syntax is as follows: ``` # Deprecated after CURRENT_RELEASE_VERSION @deprecate old_function(args) new_function(args) @@ -280,14 +280,14 @@ end @deprecate old_function(args) new_function(transform_args_for_new_function(args)) ``` The comment about the version number is only necessary if you are the first one -adding to `Deprecations.jl` after a release, otherwise please add to the +adding to `deprecations.jl` after a release, otherwise please add to the existing block. !!! note Please make sure to change to the new function everywhere in the existing OSCAR code base. Even if you think, you were the only one using the function, run a quick `grep` to make sure. When you are done, - `Deprecations.jl` should be the only place mentioning `old_function`. To + `deprecations.jl` should be the only place mentioning `old_function`. To make sure, you can start Julia with `--depwarn=yes` or even `--depwarn=error` and then run the tests. diff --git a/src/Oscar.jl b/src/Oscar.jl index ee80b891249e..a2261011fbd9 100644 --- a/src/Oscar.jl +++ b/src/Oscar.jl @@ -461,7 +461,7 @@ function test_experimental_module( test_module(test_file; new) end -include("Exports.jl") +include("exports.jl") # HACK/FIXME: remove these aliases once we have them in AA/Nemo/Hecke @alias characteristic_polynomial charpoly # FIXME @@ -549,7 +549,7 @@ include("Rings/ReesAlgebra.jl") include("NumberTheory/NmbThy.jl") -include("PolyhedralGeometry/main.jl") +include("PolyhedralGeometry/PolyhedralGeometry.jl") include("Polymake/polymake_to_oscar.jl") @@ -587,9 +587,9 @@ end include("Serialization/main.jl") -include("Aliases.jl") +include("aliases.jl") -include("Deprecations.jl") +include("deprecations.jl") const global OSCAR = Oscar const global oscar = Oscar diff --git a/src/PolyhedralGeometry/LPFiles.jl b/src/PolyhedralGeometry/LP_file_format.jl similarity index 100% rename from src/PolyhedralGeometry/LPFiles.jl rename to src/PolyhedralGeometry/LP_file_format.jl diff --git a/src/PolyhedralGeometry/main.jl b/src/PolyhedralGeometry/PolyhedralGeometry.jl similarity index 87% rename from src/PolyhedralGeometry/main.jl rename to src/PolyhedralGeometry/PolyhedralGeometry.jl index bffb7dbc0997..ebbaf1086d22 100644 --- a/src/PolyhedralGeometry/main.jl +++ b/src/PolyhedralGeometry/PolyhedralGeometry.jl @@ -18,12 +18,12 @@ include("PolyhedralComplex/standard_constructions.jl") include("SubdivisionOfPoints/constructors.jl") include("SubdivisionOfPoints/properties.jl") include("SubdivisionOfPoints/functions.jl") -include("LinearProgram.jl") -include("MixedIntegerLinearProgram.jl") -include("LPFiles.jl") -include("Groups.jl") +include("linear_program.jl") +include("mixed_integer_linear_program.jl") +include("LP_file_format.jl") +include("groups.jl") include("type_functions.jl") -include("Visualization.jl") +include("visualization.jl") include("solving_integrally.jl") include("triangulations.jl") diff --git a/src/PolyhedralGeometry/Groups.jl b/src/PolyhedralGeometry/groups.jl similarity index 100% rename from src/PolyhedralGeometry/Groups.jl rename to src/PolyhedralGeometry/groups.jl diff --git a/src/PolyhedralGeometry/LinearProgram.jl b/src/PolyhedralGeometry/linear_program.jl similarity index 100% rename from src/PolyhedralGeometry/LinearProgram.jl rename to src/PolyhedralGeometry/linear_program.jl diff --git a/src/PolyhedralGeometry/MixedIntegerLinearProgram.jl b/src/PolyhedralGeometry/mixed_integer_linear_program.jl similarity index 100% rename from src/PolyhedralGeometry/MixedIntegerLinearProgram.jl rename to src/PolyhedralGeometry/mixed_integer_linear_program.jl diff --git a/src/PolyhedralGeometry/Visualization.jl b/src/PolyhedralGeometry/visualization.jl similarity index 100% rename from src/PolyhedralGeometry/Visualization.jl rename to src/PolyhedralGeometry/visualization.jl diff --git a/src/Aliases.jl b/src/aliases.jl similarity index 100% rename from src/Aliases.jl rename to src/aliases.jl diff --git a/src/Deprecations.jl b/src/deprecations.jl similarity index 100% rename from src/Deprecations.jl rename to src/deprecations.jl diff --git a/src/Exports.jl b/src/exports.jl similarity index 100% rename from src/Exports.jl rename to src/exports.jl diff --git a/test/PolyhedralGeometry/Cone.jl b/test/PolyhedralGeometry/cone.jl similarity index 100% rename from test/PolyhedralGeometry/Cone.jl rename to test/PolyhedralGeometry/cone.jl diff --git a/test/PolyhedralGeometry/Group.jl b/test/PolyhedralGeometry/group.jl similarity index 100% rename from test/PolyhedralGeometry/Group.jl rename to test/PolyhedralGeometry/group.jl diff --git a/test/PolyhedralGeometry/LinearProgram.jl b/test/PolyhedralGeometry/linear_program.jl similarity index 100% rename from test/PolyhedralGeometry/LinearProgram.jl rename to test/PolyhedralGeometry/linear_program.jl diff --git a/test/PolyhedralGeometry/PolyhedralComplex.jl b/test/PolyhedralGeometry/polyhedral_complex.jl similarity index 100% rename from test/PolyhedralGeometry/PolyhedralComplex.jl rename to test/PolyhedralGeometry/polyhedral_complex.jl diff --git a/test/PolyhedralGeometry/PolyhedralFan.jl b/test/PolyhedralGeometry/polyhedral_fan.jl similarity index 100% rename from test/PolyhedralGeometry/PolyhedralFan.jl rename to test/PolyhedralGeometry/polyhedral_fan.jl diff --git a/test/PolyhedralGeometry/Polyhedron.jl b/test/PolyhedralGeometry/polyhedron.jl similarity index 100% rename from test/PolyhedralGeometry/Polyhedron.jl rename to test/PolyhedralGeometry/polyhedron.jl diff --git a/test/PolyhedralGeometry/runtests.jl b/test/PolyhedralGeometry/runtests.jl index d0e903e88308..465340ba4d94 100644 --- a/test/PolyhedralGeometry/runtests.jl +++ b/test/PolyhedralGeometry/runtests.jl @@ -4,13 +4,13 @@ using Oscar include("types.jl") include("iterators.jl") -include("Cone.jl") -include("Group.jl") -include("Polyhedron.jl") -include("LinearProgram.jl") -include("PolyhedralFan.jl") -include("PolyhedralComplex.jl") -include("SubdivisionOfPoints.jl") +include("cone.jl") +include("group.jl") +include("polyhedron.jl") +include("linear_program.jl") +include("polyhedral_fan.jl") +include("polyhedral_complex.jl") +include("subdivision_of_points.jl") include("extended.jl") include("timing.jl") include("solve_integrally.jl") diff --git a/test/PolyhedralGeometry/SubdivisionOfPoints.jl b/test/PolyhedralGeometry/subdivision_of_points.jl similarity index 100% rename from test/PolyhedralGeometry/SubdivisionOfPoints.jl rename to test/PolyhedralGeometry/subdivision_of_points.jl