induced_automorphism does not work for (Sub)PcGroups

[Ktrompfl]

I tried the following and subsequently get an error:

❯ julia
               _
   _       _ _(_)_     |  Documentation: https://docs.julialang.org
  (_)     | (_) (_)    |
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 1.10.0 (2023-12-25)
 _/ |\__'_|_|_|\__'_|  |  Official https://julialang.org/ release
|__/                   |

julia> using Oscar
  ___   ____   ____    _    ____
 / _ \ / ___| / ___|  / \  |  _ \   |  Combining ANTIC, GAP, Polymake, Singular
| | | |\___ \| |     / _ \ | |_) |  |  Type "?Oscar" for more information
| |_| | ___) | |___ / ___ \|  _ <   |  Manual: https://docs.oscar-system.org
 \___/ |____/ \____/_/   \_\_| \_\  |  Version 1.1.1

julia> G = small_group(2, 1)
Pc group of order 2

julia> H, f = maximal_abelian_quotient(G)
(Pc group of order 2, Hom: G -> H)

julia> A = automorphism_group(G)
Aut( <pc group of size 2 with 1 generator> )

julia> a = gen(A, 1)
[ f1 ] -> [ f1 ]

julia> induced_automorphism(f, a)
ERROR: MethodError: no method matching (::AutomorphismGroup{SubPcGroup})(::GAPGroupHomomorphism{PcGroup, PcGroup})

Closest candidates are:
  (::AutomorphismGroup{T})(::GAPGroupHomomorphism{T, T}) where T<:Oscar.GAPGroup
   @ Oscar ~/.julia/packages/Oscar/38HwK/src/Groups/homomorphisms.jl:1196
  (::AutomorphismGroup)(::GapObj)
   @ Oscar ~/.julia/packages/Oscar/38HwK/src/Groups/types.jl:541
  (::Oscar.GAPGroup)(::Oscar.BasicGAPGroupElem{T}) where T<:Oscar.GAPGroup
   @ Oscar ~/.julia/packages/Oscar/38HwK/src/Groups/GAPGroups.jl:53

Stacktrace:
 [1] induced_automorphism(f::GAPGroupHomomorphism{PcGroup, PcGroup}, mH::GAPGroupHomomorphism{PcGroup, PcGroup})
   @ Oscar ~/.julia/packages/Oscar/38HwK/src/Groups/homomorphisms.jl:1271
 [2] induced_automorphism(f::GAPGroupHomomorphism{PcGroup, PcGroup}, mH::AutomorphismGroupElem{PcGroup})
   @ Oscar ~/.julia/packages/Oscar/38HwK/src/Groups/homomorphisms.jl:1274
 [3] top-level scope
   @ REPL[10]:1

This appeared to work on Oscar 1.0.4 and probably no longer does because image(f) in induced_automorphism(...) now yields the newly introduced type SubPcGroup.

[lgoettgens]

@ThomasBreuer since you introduced SubPcGroup, could you have a look at this?

[ThomasBreuer]

Yes, I do.