Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate coeffs #393

Merged
merged 7 commits into from
Mar 20, 2021
Merged

Deprecate coeffs #393

merged 7 commits into from
Mar 20, 2021

Conversation

wbhart
Copy link
Contributor

@wbhart wbhart commented Mar 17, 2021

This is the Singular equivalent of Nemocas/AbstractAlgebra.jl#805

Of course this will fail until the new version of AbstractAlgebra is released.

This may be breaking for Oscar.

@tthsqe12
Copy link
Contributor

tthsqe12 commented Mar 17, 2021 •
edited
Loading

This is fine. It is always hard to guess what everyone's favorite abbr is. How about a decision on the noun vs verb thing, i.e. factor vs factorization? This might be hard because there are names that are nouns that cannot be verbified, and there are names that are verbs that cannot be nounified.

@wbhart
Copy link
Contributor Author

wbhart commented Mar 17, 2021

I don't think we can be consistent on that, but as far as I know the verb form is preferred.

@thofma
Copy link
Collaborator

thofma commented Mar 20, 2021

Bumped the version, but it is failing.

@wbhart
Copy link
Contributor Author

wbhart commented Mar 20, 2021

Just an import problem I think. Let's see if this works now.

@wbhart
Copy link
Contributor Author

wbhart commented Mar 20, 2021

That is not good news. :-(

I have a spelling error in AbstractAlgebra. I've made a PR to fix it. Sorry!

@wbhart
Copy link
Contributor Author

wbhart commented Mar 20, 2021

I guess this is where our new CI will really help us out when it is done!

@thofma
Copy link
Collaborator

thofma commented Mar 20, 2021

We should have waited for the 81 jobs. One of them would have told us, see also oscar-system/OscarDevTools.jl#9.

@wbhart
Copy link
Contributor Author

wbhart commented Mar 20, 2021

Yeah, but 80 of them would have failed for some other reason. :-)

Looks good now though. Yay!

@thofma thofma merged commit 8589ccb into oscar-system:master Mar 20, 2021
fingolfin pushed a commit to fingolfin/Singular.jl that referenced this pull request Jun 6, 2023
@wbhart
Deprecate coeffs (oscar-system#393)
ba38271 
* Replace coeffs -> coefficients.

* Replace lc, lt, lm.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wbhart @tthsqe12 @thofma