Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Panics in Begin and EndBlock #450

Closed
JasperSurmont opened this issue May 23, 2023 · 0 comments
Closed

Question: Panics in Begin and EndBlock #450

JasperSurmont opened this issue May 23, 2023 · 0 comments
Labels

Comments

@JasperSurmont
Copy link

Background

According to multiple sources in the Cosmos SDK ecosystem, the ABCI function BeginBlock and EndBlock should not be allowed to panic, to prevent chain halting (there is no recover in these functions). See for example here and here.

Question

The cosmos-sdk fork that Osmosis uses contains the function BeginBlock and EndBlock that explicitly panic. Additionally, the osmosis chain panics over 60 times in these functions. Can anyone explain why it is acceptable in Osmosis; why it is not a vulnerability (or why it indeed is not safe to do so)?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant