From 6238864282a8cc862b1be861326e8613cd88ce54 Mon Sep 17 00:00:00 2001
From: Hanna Modica <Hanna.Modica@bosch.io>
Date: Wed, 21 Jun 2023 16:33:31 +0200
Subject: [PATCH] feat(web-app-reporter): Always show first three tabs

Always show the rule violations, issues and vulnerabilities tabs. This
allows on the one hand the view to be more consistent, by always showing
the same tabs, and on the other hand allows to check resolutions, even if
there are no open violations, issues or vulnerabilities left.

resolves #6232
---
 .../src/components/SummaryView.js             | 141 ++++++++----------
 1 file changed, 66 insertions(+), 75 deletions(-)

diff --git a/plugins/reporters/web-app-template/src/components/SummaryView.js b/plugins/reporters/web-app-template/src/components/SummaryView.js
index de6174c39cf49..a3fd62371bb43 100644
--- a/plugins/reporters/web-app-template/src/components/SummaryView.js
+++ b/plugins/reporters/web-app-template/src/components/SummaryView.js
@@ -373,87 +373,78 @@ class SummaryView extends React.Component {
                             <Col span={22} offset={1}>
                                 <Tabs tabPosition="top" className="ort-tabs-summary-overview">
                                     {
-                                        webAppOrtResult.hasRuleViolations()
-                                        && (
-                                            <TabPane
-                                                tab={(
-                                                    <span>
-                                                        <ExceptionOutlined />
-                                                        Rule Violations (
-                                                        {
-                                                            ruleViolations.length !== unresolvedRuleViolations
-                                                            && `${unresolvedRuleViolations}/`
-                                                        }
-                                                        {ruleViolations.length}
-                                                        )
-                                                    </span>
-                                                )}
-                                                key="ort-summary-rule-violations-table"
-                                            >
-                                                <RuleViolationsTable
-                                                    onChange={
-                                                        SummaryView.onChangeRuleViolationsTable
+                                        <TabPane
+                                            tab={(
+                                                <span>
+                                                    <ExceptionOutlined />
+                                                    Rule Violations (
+                                                    {
+                                                        ruleViolations.length !== unresolvedRuleViolations
+                                                        && `${unresolvedRuleViolations}/`
                                                     }
-                                                    ruleViolations={webAppOrtResult.ruleViolations}
-                                                    showExcludesColumn={webAppOrtResult.hasExcludes()}
-                                                    state={columns.ruleViolations}
-                                                />
-                                            </TabPane>
-                                        )
+                                                    {ruleViolations.length}
+                                                    )
+                                                </span>
+                                            )}
+                                            key="ort-summary-rule-violations-table"
+                                        >
+                                            <RuleViolationsTable
+                                                onChange={
+                                                    SummaryView.onChangeRuleViolationsTable
+                                                }
+                                                ruleViolations={webAppOrtResult.ruleViolations}
+                                                showExcludesColumn={webAppOrtResult.hasExcludes()}
+                                                state={columns.ruleViolations}
+                                            />
+                                        </TabPane>
                                     }
                                     {
-                                        webAppOrtResult.hasIssues()
-                                        && (
-                                            <TabPane
-                                                tab={(
-                                                    <span>
-                                                        <BugOutlined />
-                                                        Issues (
-                                                        {
-                                                            issues.length !== unresolvedIssues
-                                                            && `${unresolvedIssues}/`
-                                                        }
-                                                        {issues.length}
-                                                        )
-                                                    </span>
-                                                )}
-                                                key="ort-summary-issues-table"
-                                            >
-                                                <IssuesTable
-                                                    issues={webAppOrtResult.issues}
-                                                    onChange={
-                                                        SummaryView.onChangeIssuesTable
+                                        <TabPane
+                                            tab={(
+                                                <span>
+                                                    <BugOutlined />
+                                                    Issues (
+                                                    {
+                                                        issues.length !== unresolvedIssues
+                                                        && `${unresolvedIssues}/`
                                                     }
-                                                    showExcludesColumn={webAppOrtResult.hasExcludes()}
-                                                    state={columns.issues}
-                                                />
-                                            </TabPane>
-                                        )
+                                                    {issues.length}
+                                                    )
+                                                </span>
+                                            )}
+                                            key="ort-summary-issues-table"
+                                        >
+                                            <IssuesTable
+                                                issues={webAppOrtResult.issues}
+                                                onChange={
+                                                    SummaryView.onChangeIssuesTable
+                                                }
+                                                showExcludesColumn={webAppOrtResult.hasExcludes()}
+                                                state={columns.issues}
+                                            />
+                                        </TabPane>
                                     }
                                     {
-                                        webAppOrtResult.hasVulnerabilities()
-                                        && (
-                                            <TabPane
-                                                tab={(
-                                                    <span>
-                                                        <SecurityScanOutlined />
-                                                        Vulnerabilities (
-                                                        {vulnerabilities.length}
-                                                        )
-                                                    </span>
-                                                )}
-                                                key="ort-summary-vulnerabilities-table"
-                                            >
-                                                <VulnerabilitiesTable
-                                                    onChange={
-                                                        SummaryView.onChangeVulnerabilitiesTable
-                                                    }
-                                                    vulnerabilities={webAppOrtResult.vulnerabilities}
-                                                    showExcludesColumn={webAppOrtResult.hasExcludes()}
-                                                    state={columns.vulnerabilities}
-                                                />
-                                            </TabPane>
-                                        )
+                                        <TabPane
+                                            tab={(
+                                                <span>
+                                                    <SecurityScanOutlined />
+                                                    Vulnerabilities (
+                                                    {vulnerabilities.length}
+                                                    )
+                                                </span>
+                                            )}
+                                            key="ort-summary-vulnerabilities-table"
+                                        >
+                                            <VulnerabilitiesTable
+                                                onChange={
+                                                    SummaryView.onChangeVulnerabilitiesTable
+                                                }
+                                                vulnerabilities={webAppOrtResult.vulnerabilities}
+                                                showExcludesColumn={webAppOrtResult.hasExcludes()}
+                                                state={columns.vulnerabilities}
+                                            />
+                                        </TabPane>
                                     }
                                     {
                                         webAppOrtResult.hasDeclaredLicensesProcessed()