From 62cf9cf5e342270ccdca75dcabd0fed7bd4e70cc Mon Sep 17 00:00:00 2001 From: Frank Viernau Date: Tue, 23 Apr 2024 10:02:25 +0200 Subject: [PATCH] test(model): Simplify several assertions via `shouldContainExactly()` Signed-off-by: Frank Viernau --- model/src/test/kotlin/OrtResultTest.kt | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/model/src/test/kotlin/OrtResultTest.kt b/model/src/test/kotlin/OrtResultTest.kt index 9dcaedce4f65..7a1a5e961609 100644 --- a/model/src/test/kotlin/OrtResultTest.kt +++ b/model/src/test/kotlin/OrtResultTest.kt @@ -25,6 +25,7 @@ import io.kotest.matchers.collections.containExactly import io.kotest.matchers.collections.containExactlyInAnyOrder import io.kotest.matchers.collections.haveSize import io.kotest.matchers.collections.shouldContainExactly +import io.kotest.matchers.collections.shouldHaveSingleElement import io.kotest.matchers.should import io.kotest.matchers.shouldBe import io.kotest.matchers.string.shouldMatch @@ -173,10 +174,7 @@ class OrtResultTest : WordSpec({ val openIssues = ortResult.getOpenIssues(Severity.WARNING) - openIssues should haveSize(1) - with(openIssues.first()) { - message shouldBe "Non-resolved issue" - } + openIssues.map { it.message } shouldHaveSingleElement "Non-resolved issue" } "omit issues with violation below threshold" { @@ -206,10 +204,7 @@ class OrtResultTest : WordSpec({ val openIssues = ortResult.getOpenIssues(Severity.WARNING) - openIssues should haveSize(1) - with(openIssues.first()) { - message shouldBe "Issue with severity 'warning'" - } + openIssues.map { it.message } shouldHaveSingleElement "Issue with severity 'warning'" } "omit excluded issues" { @@ -248,10 +243,7 @@ class OrtResultTest : WordSpec({ val openIssues = ortResult.getOpenIssues() - openIssues should haveSize(1) - with(openIssues.first()) { - message shouldBe "Included issue" - } + openIssues.map { it.message } shouldHaveSingleElement "Included issue" } }