Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPDX reporter crashes due to invalid SPDX expressions #7384

Closed
fviernau opened this issue Aug 17, 2023 · 5 comments
Closed

SPDX reporter crashes due to invalid SPDX expressions #7384

fviernau opened this issue Aug 17, 2023 · 5 comments
Labels
bug Issues that are considered to be bugs

Comments

@fviernau
Copy link
Member

Since ScanCode was configured to associate exceptions with nearby licenses, one may get license-exception combinations with IDs for exceptions which are not on the SPDX list. These are invalid in SPDX 2.x spec which in turn makes some requires check in the SPDX report fail.

Possible solutions:

  1. Add an additional option to ScanCode to only associate exceptions from the SPDX list, but not custom ones.
  2. Add a configuration option to ORT for toggling whether the SPDX expression need to conform to 2.x spec

Probably in any case the SPDX Document needs to be changed to tolerate such expressions.

@fviernau fviernau added the bug Issues that are considered to be bugs label Aug 17, 2023
@mnonnenmacher
Copy link
Member

Related PR: #7367

@sschuberth
Copy link
Member

/cc @maxhbr

@maxhbr
Copy link
Contributor

maxhbr commented Aug 17, 2023

relevant change proposal: spdx/change-proposal#4

@sschuberth
Copy link
Member

sschuberth commented Sep 1, 2023

Related PR: #7367

Can this be closed as #7399, which supersedes #7367, is merged?

@fviernau fviernau closed this as completed Sep 4, 2023
@fviernau
Copy link
Member Author

fviernau commented Sep 4, 2023

Closed as the crash is fixed. One might add a follow up e.g. as described in the ticket description though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that are considered to be bugs
Projects
None yet
Development

No branches or pull requests

4 participants