Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile: variable NODEJS_VERSION is set twice #7854

Closed
bennati opened this issue Nov 14, 2023 · 1 comment
Closed

Dockerfile: variable NODEJS_VERSION is set twice #7854

bennati opened this issue Nov 14, 2023 · 1 comment
Labels
bug Issues that are considered to be bugs docker About Docker topics

Comments

@bennati
Copy link
Contributor

bennati commented Nov 14, 2023

it is set here

ort/Dockerfile

Line 184 in cc7d534

ARG NODEJS_VERSION=20.9.0

and here

ort/Dockerfile

Line 458 in cc7d534

ARG NODEJS_VERSION=18.14.2

these non matching values cause issues with PATH.
Please remove one of them to prevent these issues in the future, thanks!
@sschuberth
Copy link
Member

these non matching values cause issues with PATH.

There's already a pending PR to fix this.

Please remove one of them to prevent these issues in the future, thanks!

Either cannot be simply removed without also making ARG global as outlined here. We welcome PRs for such a change (after the other PR has been merged).

@sschuberth sschuberth added bug Issues that are considered to be bugs docker About Docker topics labels Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issues that are considered to be bugs docker About Docker topics
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sschuberth @bennati