-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FSF license notices to use URL instead of address #2494
Conversation
Hi @jmarrero. Thanks for your PR. I'm waiting for a ostreedev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Yes, this is bound to be a large diff but anyway it should be done at some point. By the way, FSF now recommends pointing to https://www.gnu.org/licenses/ instead of using the office address, see https://www.gnu.org/licenses/gpl-howto.en.html. |
Thanks for the patch! Agreed on using the URL. That way a few years from now landlord raising the Boston rent for the FSF doesn't indirectly lead down the line to them moving again and then thousands more pull requests 😉 |
f574741
to
5a5c39d
Compare
Found this nice one liner to test locally
in rpm-software-management/rpmlint#85 and updated the text to use the URL. |
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
This PR should cleanup the errors related to
incorrect-fsf-address
https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address
as seen on:
https://fedora.softwarefactory-project.io/zuul/build/626111229f584791960b28198e5e2d4b
However this seems like a huge diff for this... if this does not provide any value I can just close it. I am confused with the error from the build but then the documentation says that
In all cases, upstream should be informed about this. This is the only requirement with respect to this error.
So this might not be a big deal to update the package.Also keeping as draft until I can test if this change removes the zuul error by local testing(hopefully).