Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FSF license notices to use URL instead of address #2494

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

jmarrero
Copy link
Member

@jmarrero jmarrero commented Dec 6, 2021

This PR should cleanup the errors related to incorrect-fsf-address
https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address

as seen on:
https://fedora.softwarefactory-project.io/zuul/build/626111229f584791960b28198e5e2d4b

However this seems like a huge diff for this... if this does not provide any value I can just close it. I am confused with the error from the build but then the documentation says that In all cases, upstream should be informed about this. This is the only requirement with respect to this error. So this might not be a big deal to update the package.

Also keeping as draft until I can test if this change removes the zuul error by local testing(hopefully).

@openshift-ci
Copy link

openshift-ci bot commented Dec 6, 2021

Hi @jmarrero. Thanks for your PR.

I'm waiting for a ostreedev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lucab
Copy link
Member

lucab commented Dec 6, 2021

Yes, this is bound to be a large diff but anyway it should be done at some point.

By the way, FSF now recommends pointing to https://www.gnu.org/licenses/ instead of using the office address, see https://www.gnu.org/licenses/gpl-howto.en.html.

@cgwalters
Copy link
Member

Thanks for the patch! Agreed on using the URL. That way a few years from now landlord raising the Boston rent for the FSF doesn't indirectly lead down the line to them moving again and then thousands more pull requests 😉

@jmarrero jmarrero force-pushed the fsf-address branch 5 times, most recently from f574741 to 5a5c39d Compare December 7, 2021 01:23
@jmarrero jmarrero marked this pull request as ready for review December 7, 2021 01:39
@jmarrero
Copy link
Member Author

jmarrero commented Dec 7, 2021

Found this nice one liner to test locally

grep -r -E '(675\s+Mass\s+Ave|59\s+Temple\s+Place|Franklin\s+Steet|02139|02111-1307)'

in rpm-software-management/rpmlint#85

and updated the text to use the URL.

@jmarrero jmarrero changed the title Update the FSF address on license notices Update FSF license notices to use URL instead of address Dec 7, 2021
@lucab
Copy link
Member

lucab commented Dec 7, 2021

/approve
/ok-to-test

Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@cgwalters cgwalters merged commit 490f515 into ostreedev:main Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants