Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust-bindings: regenerate for gtk-rs 0.15 #2743

Merged
merged 3 commits into from
Oct 27, 2022
Merged

Conversation

lucab
Copy link
Member

@lucab lucab commented Oct 25, 2022

This updates our Rust bindings to version 0.15 of the gtk-rs stack, see https://gtk-rs.org/blog/2022/01/16/new-release.html.
Notably, we now require a Rust toolchain >= 1.56 and GLib/GObject/GIO >= 2.48.

Closes: #2647

@lucab lucab changed the title [WIP] rust/ostree-sys: regenerate for gtk-rs 0.15 [WIP] rust: regenerate for gtk-rs 0.15 Oct 25, 2022
@lucab lucab changed the title [WIP] rust: regenerate for gtk-rs 0.15 [WIP] rust-bindings: regenerate for gtk-rs 0.15 Oct 25, 2022
@cgwalters
Copy link
Member

That seems easier than I'd expected! Did you hit anything surprising or problematic?

@lucab
Copy link
Member Author

lucab commented Oct 26, 2022

Did you hit anything surprising or problematic?

Notable things I spotted while assembling this PR:

  • NONE_CANCELLABLE is gone. This cascades quite a bit to consumers.
  • ostree_repo_finder_avahi_start() is actually missing the usual bool return value. May be worth replacing with a _try_start() with a better signature.
  • some misgenerated GString code on ostree_gpg_verify_result_describe*(), likely a gir-rs bug. Still need to look into it, just ignoring the two functions for now.

@lucab lucab changed the title [WIP] rust-bindings: regenerate for gtk-rs 0.15 rust-bindings: regenerate for gtk-rs 0.15 Oct 27, 2022
@lucab
Copy link
Member Author

lucab commented Oct 27, 2022

Ok, this one should be ready to merge.
Once in, we can do the semver bumps and release crates ostree-sys 0.11.0 and ostree 0.16.0.

@lucab lucab enabled auto-merge October 27, 2022 12:14
@lucab lucab merged commit fe09de9 into ostreedev:main Oct 27, 2022
@cgwalters
Copy link
Member

One thing to keep in mind - cap-std is heading to 1.0 hopefully soon: bytecodealliance/cap-std#272

And that will require another round of semver bumps for us, but it will thankfully be the last from that side.

@lucab lucab deleted the ups/gtk-rs-0.15 branch October 27, 2022 12:45
@lucab
Copy link
Member Author

lucab commented Oct 27, 2022

Ah yes, that one comes with a fairly large MSRV jump though.
On the gtk-rs there is also https://gtk-rs.org/blog/2022/10/18/new-release.html which just came out and also requires a toolchain >= 1.63.
I think we can do a semver bump here for this, and then bundle the new cap-std and gtk-rs together for another bump in a few months when the dust settles. How do you feel about this plan?

@cgwalters
Copy link
Member

SGTM

@lucab
Copy link
Member Author

lucab commented Oct 27, 2022

Crates update for this is at #2749.

I've noted down the future plans for the next semver bump with both gtk-rs and cap-std at #2750.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rust-bindings/cargo: bump to gtk-rs 0.15
2 participants