Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

World Light #4621

Open
Sajgon opened this issue Jan 13, 2024 · 2 comments
Open

World Light #4621

Sajgon opened this issue Jan 13, 2024 · 2 comments
Labels
priority: low Issues with this label won’t have the immediate focus

Comments

@Sajgon
Copy link

Sajgon commented Jan 13, 2024

DEFAULT_WORLD_LIGHT is missing from configKeys enums
registerEnumIn("configKeys", ConfigManager::DEFAULT_WORLD_LIGHT)

Also in game.h there are unused variables

  • checkLight
  • EVENT_LIGHTINTERVAL
@EPuncker
Copy link
Contributor

@ramon-bernardo can you take a look at this please?

@xmish
Copy link
Contributor

xmish commented Jan 14, 2024

Missing:

registerEnumIn("configKeys", ConfigManager::ALLOW_WALKTHROUGH);
registerEnumIn("configKeys", ConfigManager::SCRIPTS_CONSOLE_LOGS);
registerEnumIn("configKeys", ConfigManager::YELL_ALLOW_PREMIUM);
registerEnumIn("configKeys", ConfigManager::PREMIUM_TO_SEND_PRIVATE);
registerEnumIn("configKeys", ConfigManager::FORCE_MONSTERTYPE_LOAD);
registerEnumIn("configKeys", ConfigManager::DEFAULT_WORLD_LIGHT);
registerEnumIn("configKeys", ConfigManager::HOUSE_OWNED_BY_ACCOUNT);
registerEnumIn("configKeys", ConfigManager::CLEAN_PROTECTION_ZONES);
registerEnumIn("configKeys", ConfigManager::ONLY_INVITED_CAN_MOVE_HOUSE_ITEMS);
registerEnumIn("configKeys", ConfigManager::YELL_MINIMUM_LEVEL);
registerEnumIn("configKeys", ConfigManager::MINIMUM_LEVEL_TO_SEND_PRIVATE);
registerEnumIn("configKeys", ConfigManager::VIP_FREE_LIMIT);
registerEnumIn("configKeys", ConfigManager::VIP_PREMIUM_LIMIT);
registerEnumIn("configKeys", ConfigManager::DEPOT_FREE_LIMIT);
registerEnumIn("configKeys", ConfigManager::DEPOT_PREMIUM_LIMIT);

@EvilHero90 EvilHero90 added the priority: low Issues with this label won’t have the immediate focus label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low Issues with this label won’t have the immediate focus
Projects
None yet
Development

No branches or pull requests

4 participants