Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean fields can't interpret boolean translated value #14

Closed
David-YesWeDev opened this issue Apr 8, 2020 · 4 comments
Closed

Boolean fields can't interpret boolean translated value #14

David-YesWeDev opened this issue Apr 8, 2020 · 4 comments
Labels
fixed Issue is fixed and will be in the next release.

Comments

@David-YesWeDev
Copy link

Hi ! Thank you for your package ! This is great :)

Unfortunately i have a problem :( wich is that the boolean fields doesn't read correct boolean values in the database. For exemple i set this fields :

Boolean::make('Présence sur page d\'accueil', 'is_on_home')
->translatable()
->hideFromIndex(),

Boolean::make('Bannière accueil', 'is_on_banner')
->translatable()
->hideFromIndex(),

Boolean::make('Est mis en avant sur la page d\'accueil', 'is_highlighted')
->translatable()
->hideFromIndex(),

The data is correctly stored in the database (here i unchecked all cheboxes) :

is_on_home : {"fr":"0","es":"0","ma":"0"}
is_on_banner : {"fr":"0","es":"0","ma":"0"}
is_highlighted : {"fr":"0","es":"0","ma":"0"}

But when i navigate to the nova admin, my field's values are always displayed as true :

boolean-ob-bug

Do you have any idea where this might have come from?

Thank you for your help and time !

@Tarpsvo Tarpsvo added the fixed Issue is fixed and will be in the next release. label Apr 14, 2020
@Tarpsvo Tarpsvo closed this as completed Apr 14, 2020
@PaulLawton227
Copy link

What was the fix for this please? We're still on v3 of Nova - so can't use the latest version (as it requires v4)

@Tarpsvo
Copy link
Collaborator

Tarpsvo commented Jul 19, 2022

Hi @PaulLawton227! Do you have any updates on this issue? I believe it should work on Nova 3. If not, I will take a look at it.

@aliwesome
Copy link

Hey @Tarpsvo, I'm on v1.12.0 and I have this issue.

@marcelosantos89
Copy link

This problem still happen with Nova 4 and "nova-page-manager": "^5.8" (that adds nova-translatable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed Issue is fixed and will be in the next release.
Projects
None yet
Development

No branches or pull requests

5 participants