fs.watch for symbolic links

[tipiirai]

What version of Bun is running?

0.6.11

What platform is your computer?

Darwin 20.6.0 arm64 arm

What steps can reproduce the bug?

fs.watch for symbolic links to directories does not emit changes. Works on Node.

What is the expected behavior?

No response

What do you see instead?

No response

Additional information

Thanks for the awesome project!

[Hanaasagi]

Symbolic files also have this problem. Here are the steps to reproduce it:

1. Create file and symlink

$ touch testfile && ln -s testfile testlink

2. Run following code

const fs = require("fs");

// const file = "testfile";
const file = "testlink";

fs.watch(file, (eventType, filename) => {
  console.log(eventType, filename);
});

Error and traceback.

35 |       listener = () => {
36 |       };
37 |     this.#listener = listener;
38 |     try {
39 |
40 |       this.#watcher = fs.watch(path, options || {}, this.#onEvent.bind(this));
                         ^
error: NotDir Failed to watch filename
      at new FSWatcher (node:fs:40:22)
      at watch2 (node:fs:159:9)
      at /home/kumiko/zig/bun/x.js:6:0
      at globalThis (/home/kumiko/zig/bun/x.js:8:1)

• bun 0.6.12
• Linux 6.3.9-arch1-1

---

bun/src/bun.js/node/node_fs_watcher.zig

Lines 799 to 806 in d356cd5

	switch (stat.kind) {
	.sym_link => {
	var file = try std.fs.openFileAbsoluteZ(absolute_path_z, .{ .mode = .read_only });
	result.fd = file.handle;
	const _stat = try file.stat();
	result.is_file = _stat.kind == .directory;
	},

I think Line 805 should be changed to

                result.is_file = _stat.kind != .directory;

[cirospaciari]

Symbolic files also have this problem. Here are the steps to reproduce it:

1. Create file and symlink

$ touch testfile && ln -s testfile testlink

2. Run following code

const fs = require("fs");

// const file = "testfile";
const file = "testlink";

fs.watch(file, (eventType, filename) => {
  console.log(eventType, filename);
});

Error and traceback.

35 |       listener = () => {
36 |       };
37 |     this.#listener = listener;
38 |     try {
39 |
40 |       this.#watcher = fs.watch(path, options || {}, this.#onEvent.bind(this));
                         ^
error: NotDir Failed to watch filename
      at new FSWatcher (node:fs:40:22)
      at watch2 (node:fs:159:9)
      at /home/kumiko/zig/bun/x.js:6:0
      at globalThis (/home/kumiko/zig/bun/x.js:8:1)

• bun 0.6.12
• Linux 6.3.9-arch1-1

bun/src/bun.js/node/node_fs_watcher.zig

Lines 799 to 806 in d356cd5

	switch (stat.kind) {
	.sym_link => {
	var file = try std.fs.openFileAbsoluteZ(absolute_path_z, .{ .mode = .read_only });
	result.fd = file.handle;
	const _stat = try file.stat();
	result.is_file = _stat.kind == .directory;
	},

I think Line 805 should be changed to

                result.is_file = _stat.kind != .directory;

That was a big oopsie on my part, sorry about that.

[tipiirai]

Thank you @cirospaciari !