Cannot build on Illumos

[francescocarzaniga]

I am trying to build OCIS on Illumos (OmniOS zone), but it fails at

go build -v -tags '' -ldflags '-s -w -X "github.com/owncloud/ocis/ocis/pkg/version.String=eb2143d3" -X "github.com/owncloud/ocis/ocis/pkg/version.Date=20201228"' -o bin/ocis ./cmd/ocis
github.com/hpcloud/tail
# github.com/hpcloud/tail
/root/go/pkg/mod/github.com/hpcloud/tail@v1.0.0/tail.go:127:17: undefined: OpenFile
/root/go/pkg/mod/github.com/hpcloud/tail@v1.0.0/tail.go:191:20: undefined: OpenFile
gmake: *** [Makefile:109: bin/ocis] Error 2

There has been an issue open in hpcloud/tail for more than a year and a half at this point, and the package itself has not been updated in more than two years. This seems to be a viable fork, whose inclusion would fix the above error.

EDIT: The dependency seems to come from go-micro according to go mod why.

[micbar]

@refs can we confirm that?
@francescocarzaniga we can bring this up to the maintainer of go-micro, but i think we need an official release for hpcloud/tail first.

[francescocarzaniga]

@micbar Considering hpcloud/tail has seen no commits since 2018, I believe it's reasonable to assume no more official releases will be made. That's why I linked to nxadm/tail, which seems to have become the de facto drop-in substitute. I opened an issue with go-micro to switch them out but you guys pitching in as well would make this happen much sooner.

[francescocarzaniga]

Fixed upstream in go-micro v3. I have checked locally with a modified version of go-micro v2 and it works. This will be fixed when #1361 is done.

[IljaN]

This also affects DragonflyBSD builds. Fix is adding an additional buildtag in a replaced tail or looking in to the proposed tial fork.
Tail is also used in the konnectd-idp.
https://github.com/Kopano-dev/konnect/blob/master/go.sum#L90

[nxadm]

@IljaN nxadm/tail builds on DragonflyBSD and Illuminos on since nov 2019 because of this simple one-line PR:
nxadm/tail@cc4a94d#diff-28ee33a03ede1823b743b4a5cc601ee8c364a56669383959806159ad467e5d0c

[francescocarzaniga]

Now there is a new issue with Reva, see here.

[francescocarzaniga]

Now that the stable release has landed is there any interest in this?

[micbar]

Please check out cs3org/reva#3559

Testing it on my machine

1. do a go.mod replace which points to my remote reva branch

2. run

GOOS=freebsd make -C ocis clean build   

[micbar]

@francescocarzaniga It seems that i misread the reva issue. The mentioned fix is for freebsd.

[micbar]

Outdated. Please re open if still valid.