From 70b8cfaa539ea3b0b7ab2bc86fcbf7a8baf28249 Mon Sep 17 00:00:00 2001 From: DonIsaac <22823424+DonIsaac@users.noreply.github.com> Date: Thu, 1 Aug 2024 12:25:24 +0000 Subject: [PATCH] fix(linter): missing return in no-obj-calls recursion (#4594) --- crates/oxc_linter/src/rules/eslint/no_obj_calls.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/oxc_linter/src/rules/eslint/no_obj_calls.rs b/crates/oxc_linter/src/rules/eslint/no_obj_calls.rs index c08ae765119cf..27871f7937a1e 100644 --- a/crates/oxc_linter/src/rules/eslint/no_obj_calls.rs +++ b/crates/oxc_linter/src/rules/eslint/no_obj_calls.rs @@ -110,11 +110,11 @@ fn resolve_global_binding<'a, 'b: 'a>( Some(Expression::Identifier(parent_ident)) if parent_ident.name != ident.name => { - resolve_global_binding(parent_ident, decl_scope, ctx) + return resolve_global_binding(parent_ident, decl_scope, ctx) } // handles "let a = globalThis.JSON; let b = a; a();" Some(parent_expr) if parent_expr.is_member_expression() => { - global_this_member(parent_expr.to_member_expression()) + return global_this_member(parent_expr.to_member_expression()) } _ => None, }