From b4b460f425e7ced59743d743a3c1da2722def717 Mon Sep 17 00:00:00 2001
From: overlookmotel <557937+overlookmotel@users.noreply.github.com>
Date: Fri, 13 Sep 2024 12:19:54 +0000
Subject: [PATCH] refactor(semantic): `Stats` store counts as `u32` (#5754)

These counts can never exceed `u32`, so reduce size of these fields.
---
 crates/oxc_semantic/src/builder.rs | 15 ++++++++-------
 crates/oxc_semantic/src/stats.rs   |  8 ++++----
 2 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/crates/oxc_semantic/src/builder.rs b/crates/oxc_semantic/src/builder.rs
index b4f7d68150fa2..a98a798a0e97b 100644
--- a/crates/oxc_semantic/src/builder.rs
+++ b/crates/oxc_semantic/src/builder.rs
@@ -233,9 +233,9 @@ impl<'a> SemanticBuilder<'a> {
             // TODO: It would be even more efficient to calculate counts in parser to avoid
             // this extra AST traversal.
             let stats = Stats::count(program);
-            self.nodes.reserve(stats.nodes);
-            self.scope.reserve(stats.scopes);
-            self.symbols.reserve(stats.symbols, stats.references);
+            self.nodes.reserve(stats.nodes as usize);
+            self.scope.reserve(stats.scopes as usize);
+            self.symbols.reserve(stats.symbols as usize, stats.references as usize);
 
             // Visit AST to generate scopes tree etc
             self.visit_program(program);
@@ -243,11 +243,12 @@ impl<'a> SemanticBuilder<'a> {
             // Check that estimated counts accurately
             #[cfg(debug_assertions)]
             {
+                #[allow(clippy::cast_possible_truncation)]
                 let actual_stats = Stats {
-                    nodes: self.nodes.len(),
-                    scopes: self.scope.len(),
-                    symbols: self.symbols.len(),
-                    references: self.symbols.references.len(),
+                    nodes: self.nodes.len() as u32,
+                    scopes: self.scope.len() as u32,
+                    symbols: self.symbols.len() as u32,
+                    references: self.symbols.references.len() as u32,
                 };
                 Stats::assert_accurate(&actual_stats, &stats);
             }
diff --git a/crates/oxc_semantic/src/stats.rs b/crates/oxc_semantic/src/stats.rs
index 86226488d6807..e80c1a7836d1c 100644
--- a/crates/oxc_semantic/src/stats.rs
+++ b/crates/oxc_semantic/src/stats.rs
@@ -15,10 +15,10 @@ use oxc_syntax::scope::{ScopeFlags, ScopeId};
 
 #[derive(Default, Debug)]
 pub(crate) struct Stats {
-    pub nodes: usize,
-    pub scopes: usize,
-    pub symbols: usize,
-    pub references: usize,
+    pub nodes: u32,
+    pub scopes: u32,
+    pub symbols: u32,
+    pub references: u32,
 }
 
 impl Stats {