From ea32d5b1563303176cf8286d05ef257eabcf5dcd Mon Sep 17 00:00:00 2001 From: Dunqing <29533304+Dunqing@users.noreply.github.com> Date: Sat, 21 Sep 2024 07:52:51 +0000 Subject: [PATCH] fix(isolated-declarations): should print constructor assignments first (#5934) --- crates/oxc_isolated_declarations/src/class.rs | 3 ++- crates/oxc_isolated_declarations/tests/fixtures/class.ts | 5 +++++ crates/oxc_isolated_declarations/tests/snapshots/class.snap | 5 +++++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/crates/oxc_isolated_declarations/src/class.rs b/crates/oxc_isolated_declarations/src/class.rs index 5523dfc1f71dc..5065e90363874 100644 --- a/crates/oxc_isolated_declarations/src/class.rs +++ b/crates/oxc_isolated_declarations/src/class.rs @@ -402,7 +402,8 @@ impl<'a> IsolatedDeclarations<'a> { }; if let MethodDefinitionKind::Constructor = method.kind { - elements.extend( + elements.splice( + 0..0, self.transform_constructor_params_to_class_properties( function, ¶ms, ), diff --git a/crates/oxc_isolated_declarations/tests/fixtures/class.ts b/crates/oxc_isolated_declarations/tests/fixtures/class.ts index cd5a85d7113c7..3a4ee4213e62b 100644 --- a/crates/oxc_isolated_declarations/tests/fixtures/class.ts +++ b/crates/oxc_isolated_declarations/tests/fixtures/class.ts @@ -49,3 +49,8 @@ export class Bux { readonly prop3: number = 1, ) {} } + +export class PrivateFieldsWithConstructorAssignments { + private second = 0; + constructor(public first: number) {} +} \ No newline at end of file diff --git a/crates/oxc_isolated_declarations/tests/snapshots/class.snap b/crates/oxc_isolated_declarations/tests/snapshots/class.snap index 6087ed6875691..8b36375a9e3f8 100644 --- a/crates/oxc_isolated_declarations/tests/snapshots/class.snap +++ b/crates/oxc_isolated_declarations/tests/snapshots/class.snap @@ -46,3 +46,8 @@ export declare class Bux { readonly prop3: number; private constructor(); } +export declare class PrivateFieldsWithConstructorAssignments { + first: number; + private second; + constructor(first: number); +}