From f360e2c6f8ddaff9ec5b522bdb61310b8aecebd7 Mon Sep 17 00:00:00 2001
From: leaysgur <6259812+leaysgur@users.noreply.github.com>
Date: Thu, 19 Sep 2024 06:08:31 +0000
Subject: [PATCH] refactor(semantic): Remove redundunt is_leading check for
 JSDoc (#5877)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Late review for #5876 👀

`is_leading()` was already covered by `is_jsdoc()`.

https://github.com/oxc-project/oxc/blob/9115dd947afdb525cdb9c40cb851177f132b39a4/crates/oxc_ast/src/trivia.rs#L108-L110
---
 crates/oxc_semantic/src/jsdoc/builder.rs | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/crates/oxc_semantic/src/jsdoc/builder.rs b/crates/oxc_semantic/src/jsdoc/builder.rs
index 5fe844926b9c7..62a8fe2872364 100644
--- a/crates/oxc_semantic/src/jsdoc/builder.rs
+++ b/crates/oxc_semantic/src/jsdoc/builder.rs
@@ -15,10 +15,7 @@ pub struct JSDocBuilder<'a> {
 impl<'a> JSDocBuilder<'a> {
     pub fn new(source_text: &'a str, trivias: &Trivias) -> Self {
         let mut not_attached_docs: FxHashMap<u32, Vec<_>> = FxHashMap::default();
-        for comment in trivias
-            .comments()
-            .filter(|comment| comment.is_leading() && comment.is_jsdoc(source_text))
-        {
+        for comment in trivias.comments().filter(|comment| comment.is_jsdoc(source_text)) {
             not_attached_docs
                 .entry(comment.attached_to)
                 .or_default()