Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datastore: add a thorough test of deleting inventory collections #5305

Open
jgallagher opened this issue Mar 21, 2024 · 0 comments
Open

Datastore: add a thorough test of deleting inventory collections #5305

jgallagher opened this issue Mar 21, 2024 · 0 comments
Labels
database Related to database access development Bugs, paper cuts, feature requests, or other thoughts on making omicron development better

Comments

@jgallagher
Copy link
Contributor

When adding new data to inventory collections, it is easy to forget to update DataStore::inventory_delete_collection() to remove that new data, which leads to unbounded and quick growth of the new data (e.g., #5299). @smklein and @davepacheco at various times have both proposed a test roughly structured like:

  1. Create a snapshot of the database state (critically, this needs to include "potentially new tables that have been added since this test was written")
  2. Insert a collection
  3. Delete that collection
  4. Confirm that the database matches the snapshot taken in 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database Related to database access development Bugs, paper cuts, feature requests, or other thoughts on making omicron development better
Projects
None yet
Development

No branches or pull requests

1 participant