-
-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request new MegaLinter flavor #2754
Comments
That could be interesting, something like DotnetExtended :) |
Here are a few concrete examples in my project stack:
A quick search on GitHub for |
@Isalgeon that seems to be a wide use case, I'll create the flavor :) Don't hesitate to remind me by pinging me later if I forget ^^ |
This would be very appreciated!!! I use both stacks in many projects too. Can I suggest |
@Isalgeon @JohnCampionJr It's on the way, flavor will be available in beta once #2778 will be merged :) |
@Isalgeon @JohnCampionJr you can play with the new dotnetweb flavor in beta version :) https://megalinter.io/beta/flavors/dotnetweb/ Please post your feedbacks here :) |
It appears you merged to main, not beta.
As such the docker pull isn't working
|
I merged to main and it generated a beta :) It is probably not present in the github action as it is a new image (I can arrange that tomorrow) , but it is for sure present in docker hub ^^ |
@nvuillam, thanks for adding the flavor! :-) The stuff to pull down has been roughly halved, preventing the need for some custom image-picking logic. I did notice that the flavor does not contain the following linters (based on the docs): Is there a specific reason for leaving those out? All other linters from the DotNet and JS/TS flavors are included. |
OK, I'm fuzzy on exactly what I need to test it. Neither of these work uses: oxsecurity/megalinter/flavors/dotnetweb@beta uses: oxsecurity/megalinter/flavors/dotnetweb@main |
@Isalgeon i forgot to add them, but will do asap ^^ Note: do you know anyone still using coffeescript ?? |
@JohnCampionJr i'll make that work very soon and reply here :) |
@nvuillam, I don't know anyone using this, nor do my team and I, but I can imagine some teams using it in roughly the same context. I think it would be a good idea to fulfill the original request of having a flavor that combines the DotNet and JS flavors, but I'll leave it up to you whether to include it. :-) |
@Isalgeon I think no one uses coffeescript anymore, but who knows ... :) PR on the way to add coffee & react linters :) |
Is your feature request related to a problem? Please describe.
MegaLinter would run faster on my project stack of ~65 projects if I had a more optimized combination/bundle of linters, specifically for DotNet + JavaScript.
Describe the solution you'd like
A flavor that combines the DotNet and JavaScript flavors. I have yet to come up with a good name for this flavor.
Describe alternatives you've considered
I've verified whether one of the existing favors comes close to optimizing the download package size, but the only option would be the All flavor.
Additional context
Combining the two flavors would yield 67 linters, and I estimate the total image size to be ~1,5GB. That would save 1,1GB of download size. However, I know there's a tradeoff on the Docker build side.
The text was updated successfully, but these errors were encountered: