Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request new MegaLinter flavor #2754

Closed
Isalgeon opened this issue Jun 21, 2023 · 14 comments · Fixed by #2778 or #2787
Closed

Request new MegaLinter flavor #2754

Isalgeon opened this issue Jun 21, 2023 · 14 comments · Fixed by #2778 or #2787
Labels
enhancement New feature or request

Comments

@Isalgeon
Copy link
Contributor

Is your feature request related to a problem? Please describe.
MegaLinter would run faster on my project stack of ~65 projects if I had a more optimized combination/bundle of linters, specifically for DotNet + JavaScript.

Describe the solution you'd like
A flavor that combines the DotNet and JavaScript flavors. I have yet to come up with a good name for this flavor.

Describe alternatives you've considered
I've verified whether one of the existing favors comes close to optimizing the download package size, but the only option would be the All flavor.

Additional context
Combining the two flavors would yield 67 linters, and I estimate the total image size to be ~1,5GB. That would save 1,1GB of download size. However, I know there's a tradeoff on the Docker build side.

@Isalgeon Isalgeon added the enhancement New feature or request label Jun 21, 2023
@nvuillam
Copy link
Member

That could be interesting, something like DotnetExtended :)
What types of projects do you build ?
Do you have example of similar stack projects on github ?

@Isalgeon
Copy link
Contributor Author

Isalgeon commented Jun 21, 2023

Here are a few concrete examples in my project stack:

  • An ASP.NET web application (DotNet back-end) that uses JavaScript/TypeScript in the front end.
  • A DotNet + JavaScript extension library for an ASP.NET web application.

A quick search on GitHub for asp.net web application yields a representable example that is not too dissimilar to something I have in the project stack. :-)

@nvuillam
Copy link
Member

nvuillam commented Jul 1, 2023

@Isalgeon that seems to be a wide use case, I'll create the flavor :)

Don't hesitate to remind me by pinging me later if I forget ^^

@JohnCampionJr
Copy link

JohnCampionJr commented Jul 10, 2023

This would be very appreciated!!! I use both stacks in many projects too.

Can I suggest DotNetWeb perhaps for a name?

@nvuillam
Copy link
Member

@Isalgeon @JohnCampionJr It's on the way, flavor will be available in beta once #2778 will be merged :)

@nvuillam
Copy link
Member

@Isalgeon @JohnCampionJr you can play with the new dotnetweb flavor in beta version :)

https://megalinter.io/beta/flavors/dotnetweb/

Please post your feedbacks here :)

@JohnCampionJr
Copy link

It appears you merged to main, not beta.

uses: oxsecurity/megalinter/flavors/dotnetweb@main

As such the docker pull isn't working

Pull down action image 'oxsecurity/megalinter-dotnetweb:v7'
  /usr/bin/docker pull oxsecurity/megalinter-dotnetweb:v7
  Error response from daemon: manifest for oxsecurity/megalinter-dotnetweb:v7 not found: manifest unknown: manifest unknown
  Warning: Docker pull failed with exit code 1, back off 4.721 seconds before retry.
  /usr/bin/docker pull oxsecurity/megalinter-dotnetweb:v7
  Error response from daemon: manifest for oxsecurity/megalinter-dotnetweb:v7 not found: manifest unknown: manifest unknown
  Warning: Docker pull failed with exit code 1, back off [5](https://github.com/JohnCampionJr/auto/actions/runs/5508650896/jobs/10040220771#step:2:5).4[6](https://github.com/JohnCampionJr/auto/actions/runs/5508650896/jobs/10040220771#step:2:6)1 seconds before retry.
  /usr/bin/docker pull oxsecurity/megalinter-dotnetweb:v[7](https://github.com/JohnCampionJr/auto/actions/runs/5508650896/jobs/10040220771#step:2:7)
  Error response from daemon: manifest for oxsecurity/megalinter-dotnetweb:v7 not found: manifest unknown: manifest unknown
Error: Docker pull failed with exit code 1

@nvuillam
Copy link
Member

nvuillam commented Jul 10, 2023

I merged to main and it generated a beta :)

It is probably not present in the github action as it is a new image (I can arrange that tomorrow) , but it is for sure present in docker hub ^^

-> https://hub.docker.com/layers/oxsecurity/megalinter-dotnetweb/beta/images/sha256-f9b134032ef02b42c0f29bc610e5171505cdc11f58c15e9c8e9b87c782ee4a03?context=explore

@Isalgeon
Copy link
Contributor Author

Isalgeon commented Jul 10, 2023

@nvuillam, thanks for adding the flavor! :-) The stuff to pull down has been roughly halved, preventing the need for some custom image-picking logic.

I did notice that the flavor does not contain the following linters (based on the docs):

Is there a specific reason for leaving those out? All other linters from the DotNet and JS/TS flavors are included.

@JohnCampionJr
Copy link

OK, I'm fuzzy on exactly what I need to test it. Neither of these work

uses: oxsecurity/megalinter/flavors/dotnetweb@beta
uses: oxsecurity/megalinter/flavors/dotnetweb@main

@nvuillam
Copy link
Member

@Isalgeon i forgot to add them, but will do asap ^^

Note: do you know anyone still using coffeescript ??

@nvuillam
Copy link
Member

@JohnCampionJr i'll make that work very soon and reply here :)

@nvuillam nvuillam reopened this Jul 11, 2023
@Isalgeon
Copy link
Contributor Author

Note: do you know anyone still using coffeescript ??

@nvuillam, I don't know anyone using this, nor do my team and I, but I can imagine some teams using it in roughly the same context.

I think it would be a good idea to fulfill the original request of having a flavor that combines the DotNet and JS flavors, but I'll leave it up to you whether to include it. :-)

@nvuillam
Copy link
Member

@Isalgeon I think no one uses coffeescript anymore, but who knows ... :)

PR on the way to add coffee & react linters :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants