Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment inconsistency bug when reset() is called twice at the end of an episode. #104

Open
binary-husky opened this issue Dec 22, 2022 · 1 comment

Comments

@binary-husky
Copy link

We discover that when smac is reset twice at the end, the environment has unknown problems causing strange results, e.g. a model supposed to hit 95%+ win rate to reduce to 50%- win rate.

Method to reproduce:

  • find a trained model on map MMM2, freeze it for evaluation
  • change res = self._env.reset() to self._env.reset(); res=self._env.reset() (reset twice)
  • observe significant win rate decline

Although we can easily avoid reset() twice by adding some if-else,
but this is obviously a bug that can cause protential troubles.

@binary-husky
Copy link
Author

may be add some notice to warn others not to mess with reset function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant