-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Faraday to 2.5 #107
Bump Faraday to 2.5 #107
Conversation
I think we will need to update the required ruby version in the gemfile, to match up with the requires of this new dep infact, it doesn't look like there is a restriction, but there would need to be. based on my comments in slack
|
Thanks for the PR @lluis-jt! |
Awesome, thanks! |
Thanks! a pleasure. |
hey @lluis-jt - we've just had a report in pact-foundation/pact-ruby-cli#121 after this change was merged, would you be able to offer any assistance? No problem if not! |
Seems some gem from the 'pact-ruby-cli' is using the 'faraday_middleware', but I am quite lost in helping you. 😞 |
Thanks for having a quick look, I checked out ecosystem diagram https://docs.pact.io/diagrams/ecosystem#ruby-goldberg-machine and the source, and nothing else is pulling in the faraday_middleware, in the dep tree, bar an example I've created a repro which is working for me, so now awaiting a response and will take it from there |
The purpose of this PR is to just upgrade Faraday from '>= 0.9.0', '<= 2.0' to '~> 2.5'.
In the process had to remove the deprecated gem 'faraday_middleware' and thus of removing this one, we've lost the retry one. To get back the retry one, we've added 'faraday-retry', this can be seen in 'lib/pact/provider_verifier/set_up_provider_state.rb' file.x