Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Faraday to 2.5 #107

Merged
merged 5 commits into from
Aug 1, 2023
Merged

Conversation

lluis-jt
Copy link
Contributor

@lluis-jt lluis-jt commented Jul 28, 2023

The purpose of this PR is to just upgrade Faraday from '>= 0.9.0', '<= 2.0' to '~> 2.5'.
In the process had to remove the deprecated gem 'faraday_middleware' and thus of removing this one, we've lost the retry one. To get back the retry one, we've added 'faraday-retry', this can be seen in 'lib/pact/provider_verifier/set_up_provider_state.rb' file.x

@lluis-jt lluis-jt changed the title feat: Bump Faraday to 2.5 Bump Faraday to 2.5 Jul 28, 2023
@lluis-jt lluis-jt marked this pull request as ready for review July 28, 2023 11:29
@YOU54F
Copy link
Member

YOU54F commented Jul 28, 2023

I think we will need to update the required ruby version in the gemfile, to match up with the requires of this new dep

infact, it doesn't look like there is a restriction, but there would need to be.

based on my comments in slack

I assume we had to pin to lower than 2, because we used travelling-ruby to package cross-platform and that only supported up to ruby 2.4
faraday latest 1.x https://rubygems.org/gems/faraday/versions/1.10.3 shows a require of ruby 2.4
faraday 2.x moved to a require of ruby 2.6
https://rubygems.org/gems/faraday/versions/2.0.0
We’ve recently updated traveling-ruby on a fork, to package Ruby 3.2.2 runtime, so this should be possible now.
Happy to accept PR’s, but will get Beth to review as she is our Ruby expert and may know further detail, but that is my best guess

@YOU54F YOU54F requested review from bethesque and YOU54F July 28, 2023 13:51
@YOU54F
Copy link
Member

YOU54F commented Jul 28, 2023

Thanks for the PR @lluis-jt!

@bethesque bethesque merged commit bd59317 into pact-foundation:master Aug 1, 2023
13 checks passed
@bethesque
Copy link
Member

Awesome, thanks!

@lluis-jt
Copy link
Contributor Author

lluis-jt commented Aug 2, 2023

Awesome, thanks!

Thanks! a pleasure.

@YOU54F
Copy link
Member

YOU54F commented Sep 13, 2023

hey @lluis-jt - we've just had a report in pact-foundation/pact-ruby-cli#121 after this change was merged, would you be able to offer any assistance?

No problem if not!

@lluis-jt
Copy link
Contributor Author

hey @lluis-jt - we've just had a report in pact-foundation/pact-ruby-cli#121 after this change was merged, would you be able to offer any assistance?

No problem if not!

Seems some gem from the 'pact-ruby-cli' is using the 'faraday_middleware', but I am quite lost in helping you. 😞

@YOU54F
Copy link
Member

YOU54F commented Sep 14, 2023

Thanks for having a quick look,

I checked out ecosystem diagram

https://docs.pact.io/diagrams/ecosystem#ruby-goldberg-machine

and the source, and nothing else is pulling in the faraday_middleware, in the dep tree, bar an example

I've created a repro which is working for me, so now awaiting a response and will take it from there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants