Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the -multi tag from cross-platform images #116

Closed
agross opened this issue Jun 19, 2023 · 5 comments · Fixed by #118
Closed

Remove the -multi tag from cross-platform images #116

agross opened this issue Jun 19, 2023 · 5 comments · Fixed by #118

Comments

@agross
Copy link

agross commented Jun 19, 2023

Why is there a need to append -multi to the tag? If the latest tag would be cross-platform:

  • as a user you would not need to know about the -multi tag
  • users would download the same amount of data from the image registry
@YOU54F
Copy link
Member

YOU54F commented Jul 6, 2023

We are just being cautious in our roll out as the pact-cli and pact-broker images which follow the same pattern are used my many across production workloads.

Once we've assessed usage levels and any issues raised, we will promote to first class (ie without the appended -multi flag.

See here for discussion/agreement on how we would proceed

pact-foundation/pact-broker-docker#123 (comment)

@YOU54F
Copy link
Member

YOU54F commented Jul 6, 2023

users would download the same amount of data from the image registry

no they wouldn't, the images are not the same size, as they are built for different architectures and don't contain the same code...

@agross
Copy link
Author

agross commented Jul 6, 2023

no they wouldn't

docker is smart enough to just pull the parts of the image that match the CPU architecture.

@YOU54F
Copy link
Member

YOU54F commented Jul 6, 2023

that isn't the same amount of data as per your statement.

the amd64 images are tried and tested for many years. the arm64 and arm images are different, and not as rigorously tested.

@YOU54F
Copy link
Member

YOU54F commented Jul 6, 2023

size isn't the issue anyway

This was referenced Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants