Clear timeout if promise has already resolves to avoid hanging open handle

[vietanhtran16]

Checklist

• yarn run dist:ci passes on my machine
• I have followed the commit message guidelines, with messages suitable for appearing in the changelog

Description

We are getting error from jest when running it with --detectOpenHandles

Atm, the addTimeout is not clearing the timeout when the promise has resolved which is causing this issue

[vietanhtran16]

Hey @YOU54F could you help me take a look at the failed CIs? I don' think it is related to my changes

[YOU54F]

yeah that’s a bit odd, i’ll trigger a ci run from main and give this a run locally and see what’s happening.

are you seeing the error requiring this change only with certain versions of node or jest? has it previously been okay?

thanks for the change. will probably be tomorrow or most likely Friday i get a change to sort ( got a talk tomorrow afternoon )

[vietanhtran16]

yeah that’s a bit odd, i’ll trigger a ci run from main and give this a run locally and see what’s happening.

are you seeing the error requiring this change only with certain versions of node or jest? has it previously been okay?

thanks for the change. will probably be tomorrow or most likely Friday i get a change to sort ( got a talk tomorrow afternoon )

Thanks for looking into this.

I think this is probably an issue in previous version of jest too. We are on 29.5.0 atm

[vietanhtran16]

Also it is an issue with the timeout not being cleaned up properly, version of jest actually doesnt matter. It just happened to catch the issue when we were using this

[tsemerad]

@vietanhtran16 @YOU54F I just pushed a pull request that fixes this issue in a different way. I noticed that Jest recommends calling .unref() on timers to prevent open handles, so that's what I added, and it solved the problem for me.
https://github.com/pactflow/pact-msw-adapter/pull/124/files

[YOU54F]

Closing in favour of #124 which is now merged and released, thanks both