Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#IOPID-1994] Move redis to peerDependency #164

Merged
merged 1 commit into from
Jun 20, 2024
Merged

[#IOPID-1994] Move redis to peerDependency #164

merged 1 commit into from
Jun 20, 2024

Conversation

BurnedMarshal
Copy link
Contributor

List of Changes

Move redis to peerDependency

Motivation and Context

The session-manager need to chose the version of redis avoiding conflicts with the types of the exported method withSpid

How Has This Been Tested?

build

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@github-actions GitHub Actions
Copy link

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPID-1994

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

arcogabbo
arcogabbo approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@arcogabbo arcogabbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BurnedMarshal BurnedMarshal merged commit a694f33 into master Jun 20, 2024
6 checks passed
@BurnedMarshal BurnedMarshal deleted the IOPID-1994-move-redis-client-peerdeps branch June 20, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcogabbo arcogabbo arcogabbo approved these changes

@gunzip gunzip Awaiting requested review from gunzip gunzip is a code owner

@francescopersico francescopersico Awaiting requested review from francescopersico francescopersico is a code owner

@AleDore AleDore Awaiting requested review from AleDore AleDore is a code owner

@gquadrati gquadrati Awaiting requested review from gquadrati gquadrati is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BurnedMarshal @arcogabbo