Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#176261561] Aggregator types SPID configuration #61

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

BurnedMarshal
Copy link
Contributor

@BurnedMarshal BurnedMarshal commented Dec 24, 2020

This PR implements full support for "SPECIFICHE TECNICHE PER I CERTIFICATI ELETTRONICI E I METADATA
DEI SOGGETTI AGGREGATORI DI SERVIZI PUBBLICI E PRIVATI"
defined with AgiD notice n. 19 – V. 4

  • New metadata required fields ContactPerson was added
  • New strict typed configuration (IServiceProviderConfig) from notice specification

@pagopa-github-bot
Copy link
Contributor

pagopa-github-bot commented Dec 24, 2020

Warnings
⚠️ WIP keyword in PR title is deprecated, please create a Draft PR instead.
⚠️ Please include a description in the Pull Request.
⚠️ This PR changes a total of 381 LOCs, that is more than a reasonable size of 250. Consider splitting the pull request into smaller ones.

Affected stories

  • 🌟 #176261561: Aggiornare certificato e metadati SPID (nuove regole tecniche per soggetti aggregatori)

Generated by 🚫 dangerJS against bff32a3

@codecov
Copy link

codecov bot commented Dec 24, 2020

Codecov Report

Merging #61 (bff32a3) into master (56e2e28) will decrease coverage by 1.96%.
The diff coverage is 44.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
- Coverage   66.26%   64.30%   -1.97%     
==========================================
  Files          11       11              
  Lines         750      832      +82     
  Branches      117      166      +49     
==========================================
+ Hits          497      535      +38     
- Misses        252      296      +44     
  Partials        1        1              
Impacted Files Coverage Δ
src/config.ts 100.00% <ø> (ø)
src/strategy/spid.ts 37.20% <0.00%> (+0.25%) ⬆️
src/utils/saml.ts 52.83% <2.08%> (-5.95%) ⬇️
src/index.ts 64.19% <92.85%> (+4.77%) ⬆️
src/utils/middleware.ts 95.31% <100.00%> (+3.00%) ⬆️
src/utils/response.ts 45.45% <0.00%> (+9.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c789ca4...bff32a3. Read the comment docs.

@BurnedMarshal BurnedMarshal changed the title [#176261561] Aggregator types SPID configuration - WIP [#176261561] Aggregator types SPID configuration Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants