Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PPANTT-118] chore: Update Stations models with new OdP fields #323

Merged
merged 3 commits into from
Sep 18, 2024
Merged

[PPANTT-118] chore: Update Stations models with new OdP fields #323

merged 3 commits into from
Sep 18, 2024

Conversation

gioelemella
Copy link
Collaborator

@gioelemella gioelemella commented Sep 10, 2024 •
edited
Loading

List of Changes

  • updated Station model and converter with new isPaymentOptionsEnabled and restEndpoint columns fields
  • updated openapi
  • updated unit tests

Motivation and context

PPANTT#118

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

jacopocarlini
jacopocarlini requested changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@jacopocarlini jacopocarlini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK but bump the starter

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

jacopocarlini
jacopocarlini approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@jacopocarlini jacopocarlini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work

@gioelemella gioelemella merged commit 47356d2 into main Sep 18, 2024
15 of 17 checks passed
@gioelemella gioelemella deleted the PPANTT-118-update-stations-api-models-with-new-odp-fields branch September 18, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacopocarlini jacopocarlini jacopocarlini approved these changes

Assignees

@gioelemella gioelemella

Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gioelemella @jacopocarlini