Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PAGOPA-2128)] feat: Add pay_stand_in column #251

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[PAGOPA-2128)] feat: Add pay_stand_in column #251

wants to merge 2 commits into from

Conversation

cap-ang
Copy link
Contributor

@cap-ang cap-ang commented Sep 18, 2024

List of Changes

  • Add pay_stand_in column (existing debt positions will have false as the value)
  • Add payStandIn attribute in PaymentPosition entity (default true as API spec)
  • Update mapping PaymentPositionModel to PaymentPosition

Motivation and Context

  • payStandIn flag handling

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@cap-ang cap-ang self-assigned this Sep 18, 2024
@cap-ang cap-ang requested a review from a team as a code owner September 18, 2024 21:09
FedericoRuzzier
FedericoRuzzier approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@FedericoRuzzier FedericoRuzzier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FedericoRuzzier FedericoRuzzier FedericoRuzzier approved these changes

Assignees

@cap-ang cap-ang

Labels
size/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cap-ang @FedericoRuzzier