feat: script execution after rule extraction #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comment this PR with update_code to format the code. Consider to use pre-commit to format the code. |
5 tasks
andrea-deri
added a commit
to pagopa/pagopa-mocker-config
that referenced
this pull request
Mar 12, 2024
This PR permits to handle the configuration of business logic execution using dedicated scripts. The main information about the logic is defined in [this PR](pagopa/pagopa-mocker#21), this one is related only to the configuration APIs that includes the new information in the existing interfaces. #### List of Changes - Updated interface and persistence logic, including references to scripting binding - Added dedicated entity that maps the collection used for store script code to be executed by engine - Added information on `MockRuleEntity` that permits to refers to script code to be executed in runtime - Added new API for retrieve all script metadata that can be assigned to mock rule
5 tasks
andrea-deri
added a commit
to pagopa/pagopa-shared-toolbox
that referenced
this pull request
Mar 12, 2024
This PR adds the configuration of a new feature on Mocker configurator in order to handle the configuration of business logic execution using dedicated scripts. The main information about the logic is defined in [this PR](pagopa/pagopa-mocker#21). This new functionality is added: - as new visible information in mock resource view, for each mock rule that uses the scripting logic - as configurable feature either in edit and add mock rule pages #### List of Changes - Added information about bound script for each mock rule that uses it - Added section on new/edit mock rule that permits to bind script to a mock rule - Added explicative tooltips on other fields - Several other little fixes and improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a major feature made on Mocker system that provide the possibility to add dynamic logic during mocking process. This feature allows the execution of custom scripts when a specific mock rule occurs. For doing so, it is only needed to set the reference of the required script (and the input parameters which may be static or variable) to the mock rule on which the business logic is to be bound.
List of Changes
MockRuleEntitythat permits to refers to script code to be executed in runtimeSpecialRequestHeaderEntityentity in order to be used as a key-value pair for all needsMotivation and Context
This modification broadens the use cases in which Mocker can be used, adding dynamic logic that can simplify and add expressiveness to tests.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: