Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix helm #13

Merged
merged 9 commits into from
Jul 25, 2022
Merged

fix helm #13

merged 9 commits into from
Jul 25, 2022

Conversation

pasqualespica
Copy link
Contributor

List of Changes

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

github-actions[bot]
github-actions bot requested changes Jul 21, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['bug', 'enhancement', 'breaking-change', 'ignore-for-release']

@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pasqualespica pasqualespica marked this pull request as ready for review July 21, 2022 16:11
@pasqualespica pasqualespica requested review from a team, aomegax and giovanniberti and removed request for a team July 21, 2022 16:11
@alessio-acitelli alessio-acitelli added the bug Something isn't working label Jul 25, 2022
pasqualespica
pasqualespica commented Jul 25, 2022
View reviewed changes
Copy link
Contributor Author

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacopocarlini @aomegax we shall remove cosmos dev key reference

@pasqualespica pasqualespica merged commit 71e62a8 into main Jul 25, 2022
@pasqualespica pasqualespica deleted the fix-gps-aks-deploy branch July 25, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions approved these changes

@aomegax aomegax Awaiting requested review from aomegax

@giovanniberti giovanniberti Awaiting requested review from giovanniberti

Assignees

@pasqualespica pasqualespica

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pasqualespica @alessio-acitelli