Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: App insights #24

Merged
merged 6 commits into from
Sep 1, 2022
Merged

fix: App insights #24

merged 6 commits into from
Sep 1, 2022

Conversation

jacopocarlini
Copy link
Contributor

List of Changes

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

github-actions[bot]
github-actions bot requested changes Aug 5, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['bug', 'enhancement', 'breaking-change', 'ignore-for-release']

@pasqualespica pasqualespica marked this pull request as ready for review August 11, 2022 07:57
pasqualespica
pasqualespica requested changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good

helm/values-dev.yaml Outdated
@@ -84,6 +84,7 @@ microservice-chart:
LOGGING_LEVEL: "INFO"
envSecret:
COSMOS_KEY: cosmos-gps-weu-d-pkey
APPLICATIONINSIGHTS_CONNECTION_STRING: ai-connection-string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on infra we added a new secret directly via tf.
with name convection ai-%s-connection-string

@pasqualespica pasqualespica changed the title app insights fix: App insights Sep 1, 2022
pasqualespica
pasqualespica approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pasqualespica pasqualespica merged commit f1208ca into main Sep 1, 2022
@pasqualespica pasqualespica deleted the app-insight branch September 1, 2022 13:42
@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqualespica pasqualespica pasqualespica approved these changes

@github-actions GitHub Actions GitHub Actions approved these changes

@aomegax aomegax Awaiting requested review from aomegax

@giovanniberti giovanniberti Awaiting requested review from giovanniberti

Assignees

@jacopocarlini jacopocarlini

Labels
ignore-for-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacopocarlini @pasqualespica