Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: PPD-206 crud gps #5

Merged
merged 41 commits into from
Jun 30, 2022
Merged

feat: PPD-206 crud gps #5

merged 41 commits into from
Jun 30, 2022

Conversation

alessio-acitelli
Copy link
Contributor

@alessio-acitelli alessio-acitelli commented Jun 22, 2022 •
edited
Loading

List of Changes

  • crud api to allow a credit institution to subscribe to a service
  • get api to obtain the services registered in the system

Motivation and Context

  • new developments for spontaneous payments service

How Has This Been Tested?

Manual test and JUNIT Test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

aacitelli added 11 commits June 20, 2022 14:40
[PPD-206] crud gps: added enrollments api (no business code)
492b8e4
[PPD-206] crud gps: added services api (no business code)
de8b9d6
Merge branch 'PPD-206-CRUD-GPS' of
685f01a 
https://github.com/pagopa/pagopa-spontaneous-payments into
PPD-206-CRUD-GPS
[PPD-206] crud gps: updated openapi
45f8e3a
Merge branch 'PPD-206-CRUD-GPS' of https://github.com/pagopa/pagopa-s…
7c9700d 
…pontaneous-payments into PPD-206-CRUD-GPS
[PPD-206] crud gps: first DRAFT api impl
f2338ef
Merge branch 'PPD-206-CRUD-GPS' of https://github.com/pagopa/pagopa-s…
63fa75f 
…pontaneous-payments into PPD-206-CRUD-GPS
[PPD-206] crud gps: added create business code
c0e6e85
Merge branch 'PPD-206-CRUD-GPS' of https://github.com/pagopa/pagopa-s…
14d4561 
…pontaneous-payments into PPD-206-CRUD-GPS
[PPD-206] crud gps: all enrollments crud impl
68959e4
Merge branch 'PPD-206-CRUD-GPS' of https://github.com/pagopa/pagopa-s…
29e6cf4 
…pontaneous-payments into PPD-206-CRUD-GPS
github-actions[bot]
github-actions bot requested changes Jun 22, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['bug', 'enhancement', 'breaking-change', 'ignore-for-release']

@alessio-acitelli alessio-acitelli added the enhancement New feature or request label Jun 22, 2022
jacopocarlini
jacopocarlini reviewed Jun 24, 2022
View reviewed changes
...va/it/gov/pagopa/spontaneouspayment/mapper/ConvertOrganizationModelToOrganizationEntity.java Outdated Show resolved Hide resolved
src/main/java/it/gov/pagopa/spontaneouspayment/config/MappingsConfiguration.java Show resolved Hide resolved
src/main/java/it/gov/pagopa/spontaneouspayment/service/EnrollmentsService.java Outdated Show resolved Hide resolved
src/main/java/it/gov/pagopa/spontaneouspayment/service/EnrollmentsService.java Outdated Show resolved Hide resolved
src/main/java/it/gov/pagopa/spontaneouspayment/service/EnrollmentsService.java Outdated Show resolved Hide resolved
src/main/java/it/gov/pagopa/spontaneouspayment/service/EnrollmentsService.java Outdated Show resolved Hide resolved
src/main/java/it/gov/pagopa/spontaneouspayment/service/EnrollmentsService.java Outdated Show resolved Hide resolved
src/main/java/it/gov/pagopa/spontaneouspayment/service/EnrollmentsService.java Outdated Show resolved Hide resolved
@pasqualespica pasqualespica changed the title Ppd 206 crud gps feat: PPD-206 crud gps Jun 27, 2022
@pasqualespica pasqualespica marked this pull request as ready for review June 27, 2022 10:38
@pasqualespica pasqualespica requested review from a team, aomegax and jacopocarlini June 27, 2022 10:38
@pagopa pagopa deleted a comment from sonarcloud bot Jun 27, 2022
jacopocarlini
jacopocarlini approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@jacopocarlini jacopocarlini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

98.2% 98.2% Coverage
0.0% 0.0% Duplication

@alessio-acitelli alessio-acitelli merged commit 10831a5 into main Jun 30, 2022
@alessio-acitelli alessio-acitelli deleted the PPD-206-CRUD-GPS branch June 30, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacopocarlini jacopocarlini jacopocarlini approved these changes

@github-actions GitHub Actions GitHub Actions approved these changes

@aomegax aomegax Awaiting requested review from aomegax

Assignees

@alessio-acitelli alessio-acitelli

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alessio-acitelli @jacopocarlini @pasqualespica