Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SELC-4483] Feat: Added createUser and AddUserRole v2 API #385

Merged
merged 5 commits into from
Mar 27, 2024

Conversation

flaminiaScarciofolo
Copy link
Collaborator

@flaminiaScarciofolo flaminiaScarciofolo commented Mar 21, 2024

List of Changes

  • Added createUser V2 API
  • Added AddUserRole V2 API

Motivation and Context

In order to migrate user business logic to selfcare-user ms from ms-core we need to expose v2 API for user's creation

How Has This Been Tested?

local env

Screenshots (if appropriate):

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@flaminiaScarciofolo flaminiaScarciofolo changed the base branch from main to release-uat March 21, 2024 14:19
@flaminiaScarciofolo flaminiaScarciofolo changed the title Feature/selc 4483 [SELC-4483] Feat: Added createUser and AddUserRole v2 API Mar 21, 2024
@flaminiaScarciofolo flaminiaScarciofolo marked this pull request as ready for review March 21, 2024 14:27
@flaminiaScarciofolo flaminiaScarciofolo requested a review from a team as a code owner March 21, 2024 14:27
Copy link

sonarcloud bot commented Mar 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
5.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

# Conflicts:
#	core/src/main/java/it/pagopa/selfcare/dashboard/core/UserV2ServiceImpl.java
# Conflicts:
#	app/src/main/resources/swagger/api-docs.json
#	connector/rest/src/main/java/it/pagopa/selfcare/dashboard/connector/rest/UserConnectorImpl.java
#	connector/rest/src/test/java/it/pagopa/selfcare/dashboard/connector/rest/UserConnectorImplTest.java
#	web/src/main/java/it/pagopa/selfcare/dashboard/web/controller/InstitutionV2Controller.java
#	web/src/test/java/it/pagopa/selfcare/dashboard/web/controller/InstitutionV2ControllerTest.java
Copy link

sonarcloud bot commented Mar 27, 2024

@flaminiaScarciofolo flaminiaScarciofolo merged commit 3a48048 into release-uat Mar 27, 2024
2 of 3 checks passed
@flaminiaScarciofolo flaminiaScarciofolo deleted the feature/SELC-4483 branch March 27, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants