[SELC-4590] feat: Added V2 API for tokenExchange and billing tokenExchange #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
# Conflicts: # connector/rest/src/main/java/it/pagopa/selfcare/dashboard/connector/rest/UserConnectorImpl.java
| } | ||
| } | ||
|
|
||
| private Institution retrieveInstitution(String institutionId, List<ProductGrantedAuthority> productGrantedAuthorities, boolean isBillingToken) { |
There was a problem hiding this comment.
Could we move this logic into a separate service (adding also a mapper) avoding to have private methods - or at least a part of them - into this service?
|
|
||
| @GetMapping(value = "exchange") | ||
| @ResponseStatus(HttpStatus.OK) | ||
| @ApiOperation(value = "", notes = "${swagger.dashboard.token.api.exchange}") |
There was a problem hiding this comment.
As mentioned in previous pull requests, we should add a specific operation identifier for the endpoints
|
manuraf
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
Added V2 API for tokenExchange and billing tokenExchange
Motivation and Context
With a view to migrating to API v2, it is necessary to expose this api as internally it uses user authorities to perform business logic
How Has This Been Tested?
local env.
Screenshots (if appropriate):
Checklist: