Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SELC-4385] feat: Added dependency and configuration of product libs #426

Merged
merged 12 commits into from
May 7, 2024

Conversation

giulia-tremolada
Copy link
Collaborator

List of Changes

  • Added dependency and configuration of product libs
  • Add mapper to manage different objects
  • Align unit tests

Motivation and Context

This change was needed to use product library instead of product microservice to retrieve product data.

How Has This Been Tested?

It was tested by running the microservice locally

Screenshots (if appropriate):

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@giulia-tremolada giulia-tremolada marked this pull request as ready for review May 7, 2024 13:42
@giulia-tremolada giulia-tremolada requested a review from a team as a code owner May 7, 2024 13:42
Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@manuraf manuraf merged commit 4758d6d into main May 7, 2024
13 of 14 checks passed
@manuraf manuraf deleted the feature/SELC-4385-v2 branch May 7, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants