Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SELC-5327] Feat: Added API to verify if there is an onboarding in PENDING status #474

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

flaminiaScarciofolo
Copy link
Collaborator

List of Changes

  • Added API to verify if there is an onboarding in PENDING or TOBEVALIDATED status given the productId and institutionId.

Motivation and Context

We need this API to print error message when a user tries to perform onboarding for a product for which there is already a request in progress

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

…or TOBEVALIDATED status given the productId and institutionId.
@flaminiaScarciofolo flaminiaScarciofolo requested a review from a team as a code owner August 5, 2024 06:51
Copy link

sonarcloud bot commented Aug 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@flaminiaScarciofolo flaminiaScarciofolo merged commit 948a52d into main Aug 5, 2024
6 of 7 checks passed
@flaminiaScarciofolo flaminiaScarciofolo deleted the feature/SELC-5327 branch August 5, 2024 10:25
},
{
name = "ONBOARDING_URL"
value = "https://selc-d-onboarding-ms-ca"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be http:// instead of https

},
{
name = "ONBOARDING_URL"
value = "https://selc-p-pnpg-onboarding-ms-ca"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

},
{
name = "ONBOARDING_URL"
value = "https://selc-p-onboarding-ms-ca"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

},
{
name = "ONBOARDING_URL"
value = "https://selc-u-pnpg-onboarding-ms-ca"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

},
{
name = "ONBOARDING_URL"
value = "https://selc-u-onboarding-ms-ca"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants