Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Class-based View should set provide_automatic_options attr in as_view #2251

Closed
davidism opened this issue Apr 21, 2017 · 1 comment
Closed

Class-based View should set provide_automatic_options attr in as_view #2251

davidism opened this issue Apr 21, 2017 · 1 comment
Labels
good first issue

Comments

@davidism
Copy link
Member

davidism commented Apr 21, 2017 •
edited
Loading

Deprecate in favor of #2249, #1489, #1488, which adds the arg to add_url_rule. We couldn't figure out if there was a reason for doing it with an attribute originally.
@davidism
Copy link
Member Author

Ah, maybe it was for supporting View classes, like View.methods, although the View class doesn't set this in as_view right now.

@davidism davidism changed the title Deprecate the provide_automatic_options attr on view functions Class-based View should set provide_automatic_options attr in as_view Apr 21, 2017
@ka7eh ka7eh mentioned this issue May 23, 2017
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidism