Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish CalVer tags for linux/arm64 platform builds #564

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Jul 1, 2024

The base-image, base-notebook and pangeo-notebook Docker images only had linux/amd64 platform available on the latest and CalVer tags (see e.g. pangeo-notebook:2024.06.28), whereas the master tag has both linux/amd64 and linux/arm64:

image

Need to use the --platform flag when doing docker pull or docker push, so that the linux/arm64 images will be made available for latest and Calver tags.

Patches #399

The base-image, base-notebook and pangeo-notebook Docker images only had linux/amd64 platform available on the CalVer tags. Need to use the `--platform` flag when doing `docker pull` or `docker push` to explicitly tag the linux/arm64 images too.
@weiji14 weiji14 self-assigned this Jul 1, 2024
Copy link
Contributor

github-actions bot commented Jul 1, 2024

Binder 👈 Try on Mybinder.org!

Copy link
Member

@scottyhq scottyhq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@weiji14 weiji14 marked this pull request as ready for review July 1, 2024 07:30
@weiji14
Copy link
Member Author

weiji14 commented Jul 1, 2024

I haven't tested this, but you can merge this in @scottyhq and tag a new version to see if it works.

@scottyhq scottyhq merged commit 7edf75a into master Jul 1, 2024
6 checks passed
@scottyhq scottyhq deleted the linux_arm64_tags branch July 1, 2024 18:45
@scottyhq
Copy link
Member

scottyhq commented Jul 2, 2024

This didn't quite work... But fortunately it's okay to break things ;)

I think this is what we need to do:
docker/buildx#1744 (comment)

# TAG -> master -> date / latest
docker buildx imagetools create pangeo/base-image:master -t pangeo/base-image:latest -t pangeo/base-image:2024.07.02

docker buildx imagetools create quay.io/pangeo/base-image:master -t quay.io/pangeo/base-image:latest -t quay.io/pangeo/base-image:2024.07.02

This also looks useful! https://github.com/regclient/regclient

@scottyhq
Copy link
Member

scottyhq commented Jul 2, 2024

🚀 Fixed for images>2024.07.02 https://github.com/pangeo-data/pangeo-docker-images/actions/runs/9767498538

@weiji14
Copy link
Member Author

weiji14 commented Jul 2, 2024

Ah nice, that docker buildx method looks much cleaner, less lines of code to deal with! Which reminds me, maybe we should revisit buildx a bit more, xref #357.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants