Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use output_directory in javac hermetic compile #6046

Closed
baroquebobcat opened this issue Jun 28, 2018 · 3 comments
Closed

use output_directory in javac hermetic compile #6046

baroquebobcat opened this issue Jun 28, 2018 · 3 comments

Comments

@baroquebobcat
Copy link
Contributor

Once #5709 has been implemented, we need to update javac hermetic compile to collect the classes directory and the context jar rather than just individual files.

@stuhood
Copy link
Sponsor Member

stuhood commented Jun 28, 2018

Note that it is likely also an option to enable-by-default and then deprecate the use-classpath-jars option. You could then remove the loose classfile output entirely.

@stuhood
Copy link
Sponsor Member

stuhood commented Jun 28, 2018

Another potential tool in the toolbelt is to add a flag to zinc to jar up the output directory after running, which would avoid needing multiple processes.

@baroquebobcat
Copy link
Contributor Author

baroquebobcat commented Jun 29, 2018

Oh right, we could have our pants zinc wrapper do it. That's a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants