Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench-bot: provide raw .json benchmark results as artifacts #107

Closed
koute opened this issue Sep 21, 2022 · 0 comments · Fixed by paritytech/pipeline-scripts#82
Closed

bench-bot: provide raw .json benchmark results as artifacts #107

koute opened this issue Sep 21, 2022 · 0 comments · Fixed by paritytech/pipeline-scripts#82
Assignees

Comments

@koute
Copy link

koute commented Sep 21, 2022

When you trigger the bench bot it uploads a zip file with a diff of the weights (for example, paritytech/substrate#12280 (comment)). Could we make it so that it also uploads the raw .json files with the raw benchmark measurements inside this zip file? (This requires an extra argument --json-file=$filename.json to be passed to the benchmark invocation to get those files generated.)

This would be very useful for raw performance comparisons, since using weights for this is not ideal as they are a result of a linear regression, so comparing them to measure a change in performance is tricky/not always correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants