Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Prepare polkadot-v0.9.41 branch #2442

Closed
jasl opened this issue Apr 11, 2023 · 6 comments
Closed

Prepare polkadot-v0.9.41 branch #2442

jasl opened this issue Apr 11, 2023 · 6 comments

Comments

@jasl
Copy link
Contributor

jasl commented Apr 11, 2023

Hi, I see Polkadot v0.9.41 fixed a few client issues, our users report using our latest node (based on polkadot-v0.9.40) meets syncing performance regression, I guess it might be related.

could you make a polkadot-v0.9.41 for Cumulus?

@bkchr
Copy link
Member

bkchr commented Apr 11, 2023

@EgorPopelyaev could you please do this?

@EgorPopelyaev
Copy link
Contributor

polkadot-v0.9.41 branch is ready

@jasl
Copy link
Contributor Author

jasl commented Apr 11, 2023

polkadot-v0.9.41 branch is ready

Thank you!

@jasl jasl closed this as completed Apr 11, 2023
@jasl
Copy link
Contributor Author

jasl commented Apr 11, 2023

@EgorPopelyaev sorry, this look not compile

error[E0046]: not all trait items implemented, missing: `best_hash`
   --> /Users/jasl/.cargo/git/checkouts/cumulus-59522f43471fa161/fc7cad7/client/relay-chain-minimal-node/src/blockchain_rpc_client.rs:307:1
    |
307 | impl AuthorityDiscovery<Block> for BlockChainRpcClient {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `best_hash` in implementation
    |
    = help: implement the missing item: `fn best_hash(&'life0 self) -> Pin<Box<(dyn futures::Future<Output = Result<<Block as BlockT>::Hash, sc_authority_discovery::Error>> + std::marker::Send + 'async_trait)>> { todo!() }`

error[E0560]: struct `Params<_>` has no field named `chain`
  --> /Users/jasl/.cargo/git/checkouts/cumulus-59522f43471fa161/fc7cad7/client/relay-chain-minimal-node/src/network.rs:75:3
   |
75 |         chain: client.clone(),
   |         ^^^^^ `Params<_>` does not have this field
   |
   = note: available fields are: `role`, `executor`, `network_config`, `protocol_id`, `genesis_hash` ... and 5 others

Some errors have detailed explanations: E0046, E0560.
For more information about an error, try `rustc --explain E0046`.
error: could not compile `cumulus-relay-chain-minimal-node` due to 2 previous errors
warning: build failed, waiting for other jobs to finish...

@jasl jasl reopened this Apr 11, 2023
@jasl
Copy link
Contributor Author

jasl commented Apr 11, 2023

Need to cherrypick #2401 and #2385

@bkchr
Copy link
Member

bkchr commented Apr 11, 2023

Yeah that was my fault! Fixed!

@bkchr bkchr closed this as completed Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants