Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Move pallet-asset-tx-payment into Substrate #688

Closed
apopiak opened this issue Oct 20, 2021 · 3 comments · Fixed by paritytech/substrate#10127
Closed

Move pallet-asset-tx-payment into Substrate #688

apopiak opened this issue Oct 20, 2021 · 3 comments · Fixed by paritytech/substrate#10127
Assignees
Labels
T7-system_parachains This PR/Issue is related to System Parachains.

Comments

@apopiak
Copy link
Contributor

apopiak commented Oct 20, 2021

There is nothing cumulus specific about pallet-asset-tx-payment so it makes sense to upstream it to the Substrate repo.
As it wraps and extends pallet-transaction-payment it makes sense for it to live there.

@apopiak apopiak added the T7-system_parachains This PR/Issue is related to System Parachains. label Oct 20, 2021
@nuke-web3
Copy link
Contributor

This will be a minor breaking change on the next release, right? Deps will need to be updated in Cargo (only) - anything else that it might imply?

@georgesdib
Copy link
Contributor

georgesdib commented Oct 30, 2021

I have taken a stab at this in paritytech/substrate#10127
The corresponding cumulus PR is #712 but, correct me if I am wrong, I will need to update Cargo.lock only after the substrate PR is merged.

@apopiak
Copy link
Contributor Author

apopiak commented Nov 5, 2021

@georgesdib You will need to set the dependency of #712 to your substrate branch and communicate to the bot that it is the companion for paritytech/substrate#10127

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T7-system_parachains This PR/Issue is related to System Parachains.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants