Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[asset-conversion] Add runtime api to polkadot-js/api #108

Closed
bkontur opened this issue Jul 14, 2023 · 10 comments · Fixed by polkadot-js/api#5694
Closed

[asset-conversion] Add runtime api to polkadot-js/api #108

bkontur opened this issue Jul 14, 2023 · 10 comments · Fixed by polkadot-js/api#5694
Assignees

Comments

@bkontur
Copy link
Contributor

bkontur commented Jul 14, 2023

E.g.: FungiblesApi: https://github.com/polkadot-js/api/blob/3f90f72bd69c49a7ef6902366572c90c1efcdb52/packages/types/src/interfaces/fungibles/runtime.ts

@jsidorenko
Copy link
Contributor

polkadot-js/api#5694

@joepetrowski joepetrowski transferred this issue from paritytech/cumulus Aug 24, 2023
@joepetrowski
Copy link
Contributor

Needs polkadot-js/api#5700

@NachoPal
Copy link
Contributor

Can it be closed? both PRs are already merged, not sure if there is still something missing or not.

@jsidorenko
Copy link
Contributor

As I see, this issue is still open: #1129 ,@bkontur, could you comment on this pls?

@bkontur
Copy link
Contributor Author

bkontur commented Jan 25, 2024

iirc, initially, we've added some stuff to the polkadot.js, but I am not sure if it is still compatible, because there were several refactors in asset-conversion pallet, so we should check this.

@franciscoaguirre Cisco has already fixed some stuff within XCMv4, I would say we need to revisit that #1129 again, what would be the best option

@franciscoaguirre
Copy link
Contributor

I pinned version 3 so we can do a storage migration whenever

@bkontur
Copy link
Contributor Author

bkontur commented Jan 25, 2024

yes, one thing is storage and another thing is public APIs for indexers/wallets and so on, maybe for them it would be better to use Versioned* stuff, not to break when we change XCM version for storage items, if Location is not compatible.

Another thing, I think we should maybe add some try-runtime / try-state stuff, which would check actual data if they are compatible with actual XCM version used for storage items - but this would be a separate issue. At least, we will see if we can do runtime upgrade or not.

@kianenigma
Copy link
Contributor

Shouldn't this issue be in PJS apps?

@bkchr
Copy link
Member

bkchr commented Jul 29, 2024

Yeah, it should be.

@bkchr
Copy link
Member

bkchr commented Jul 29, 2024

polkadot-js/api#5694 but also looks like it was already done.

@bkchr bkchr closed this as completed Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants